← Back to issue list

_filedir takes an extension, not a glob

View original Github issue

Metadata

Project
snapcraft
Number
#933
Type
pull request
State
merged
Author
chipaca
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #933 (commit 5c41e4bc) changed `_filedir "*.snap"` to `_filedir snap` in the bash completion, fixing tab-completion that skipped .snap files containing multiple dots.

Resolution: closed resolved

Reason: The one-line change was merged as commit 5c41e4bc5 ("cli: _filedir takes an extension, not a glob (#933)"), approved by sergiusens who confirmed completion now lists xyzzy.snap alongside xyzzx.two.snap.

Evaluated by: mr-cal-bot

No scores available.

Issue body

`_filedir "*.snap"` means only files that match `*.*.snap` get tab-completed.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #933 (commit 5c41e4bc) changed `_filedir "*.snap"` to `_filedir snap` in the bash completion, fixing tab-completion that skipped .snap files containing multiple dots.
stealth/space-bunny-alpha — closed resolved Fixed in merged PR #933 (commit 5c41e4bc) by passing snap rather than *.snap to _filedir, restoring tab completion for snap files with multiple dots.
qwen/qwen3.6-35b-a3b — — Merged a fix for a bash completion bug where _filedir "*.snap" incorrectly filtered tab-completion, hiding valid snap files. Reviewers approved after the author demonstrated the corrected behavior. CI passed and the change was merged.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix for _filedir tab completion. The function incorrectly treated extension arguments as globs, filtering valid .snap files. The author demonstrated the bug with a reproduction case, and the reviewer confirmed the fix before merging.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.