← Back to issue list

Incorporate all part properties into state tracking.

View original Github issue

Metadata

Project
snapcraft
Number
#937
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #937 as commit 9212dac6d, adding all pull, build, stage, and prime part properties to state tracking and fixing LP #1646289.

Resolution: closed resolved

Reason: PR #937 was merged into Snapcraft as commit 9212dac6d. It added complete part-property tracking across all lifecycle states, resolving the linked state-tracking defect.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This PR fixes LP: [#1646289](https://bugs.launchpad.net/snapcraft/+bug/1646289) by adding all part properties into state tracking. The state->property map is as follows: **Pull State**: - plugin - stage-packages - source - source-commit - source-depth - source-tag - source-type - source-branch - source-subdir **Build State**: - after - build-packages - disable-parallel - organize **Stage State**: - stage - filesets **Prime State**: - snap Note that this change will mark old trees dirty due to the new options being included in the state tracking.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #937 as commit 9212dac6d, adding all pull, build, stage, and prime part properties to state tracking and fixing LP #1646289.
stealth/space-bunny-alpha — closed resolved Merged #937 into Snapcraft, adding all part properties to state tracking across pull, build, stage and prime. The change fixes LP #1646289.
qwen/qwen3.6-35b-a3b — — Merged after resolving reviewer concerns on dirty tree tracking. Incorporated all part properties into state tracking to fix LP: #1646289, ensuring accurate rebuild detection across build phases. CI passed.
qwen3.6-35b-a3b-mtp-q6 — — Merged into master. Fixes LP#1646289 by tracking all part properties across build phases. Addressed legacy tests, resolved conflicts, and incorporated feedback. Merged after addressing coverage and architectural notes.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1646289 snapcraft doesn't include all part properties in state tracking snapcraft (launchpad) closed Fixed by merged PR snapcore/snapcraft#937 (commit 9212dac6d), adding all part properties, including stage-packages, to pull, build, stage, and prime state tracking.
74%
#381 Improve per-step state tracking. snapcraft merged Merged PR #381 via commit 3cc0049cd, replacing the single state file with per-step state files and resolving LP #1558810.
71%