← Back to issue list

sources: refactor script source into module.

View original Github issue

Metadata

Project
snapcraft
Number
#967
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged refactoring of the Script source into a dedicated module at sources/_script.py, including basic unit tests. Approved, passed CI, and advances progress on Launchpad bug #1648906.

Suggested action: —

No scores available.

Issue body

This PR makes more progress on LP: [#1648906](https://bugs.launchpad.net/snapcraft/+bug/1648906) by extracting the Script source into `sources/_script.py`. It also implements some basic tests for the Script source.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged refactoring of the Script source into a dedicated module at sources/_script.py, including basic unit tests. Approved, passed CI, and advances progress on Launchpad bug #1648906.
qwen3.6-35b-a3b-mtp-q6 — — Merged into master, extracting the Script source into sources/_script.py and adding initial tests. This refactoring advances progress on Launchpad bug #1648906 while maintaining code coverage above 96 percent.
qwen3.6-35b-a3b-mtp-q6 — — Merged into master. Refactored Script source into sources/_script.py module and added basic tests. Advances progress on Launchpad bug #1648906.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#961 sources: refactor local source into module. snapcraft merged Merged after approval and CI. Refactored the local source into sources/_local.py, advancing Launchpad bug #1648906. Modified four files with a +236/-191 line change and slightly increased overall code coverage.
76%
#957 sources: refactor base sources into module. snapcraft merged Merged following two approvals and passing CI checks. Refactored Base and FileBase sources into sources/_base.py, increasing test coverage by 1.20% and progressing work on Launchpad bug #1648906.
76%
#968 sources: refactor subversion source into module. snapcraft merged Merged refactoring that extracts the Subversion source handler into a dedicated module. Advances Launchpad bug #1648906, passed coverage checks, and received author approval. Net change: +170/-129 lines across four files.
71%
#964 sources: refactor git source into module. snapcraft merged Merged a refactor extracting Git source logic into sources/_git.py. Approved by reviewer, passed CI, and slightly improved code coverage as part of ongoing bug fix LP: #1648906.
71%