← Back to issue list

style: ensure ruff picks up pydantic.validator for class methods

View original Github issue

Metadata

Project
starbase
Number
#134
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR canonical/starbase#134 (commit 3d09653) adding ruff pep8-naming classmethod-decorators for pydantic.validator/root_validator in pyproject.toml, fixing N805 linting on validator class methods.

Resolution: closed resolved

Reason: The PR was approved and merged into main as commit 3d09653 ('style: ensure ruff picks up pydantic.validator for class methods (#134)'), adding the pep8-naming classmethod-decorators ruff setting.

Evaluated by: mr-cal-bot

No scores available.

Issue body

see: https://docs.astral.sh/ruff/settings/#pep8-naming-classmethod-decorators - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR canonical/starbase#134 (commit 3d09653) adding ruff pep8-naming classmethod-decorators for pydantic.validator/root_validator in pyproject.toml, fixing N805 linting on validator class methods.
stealth/space-bunny-alpha — closed resolved Merged Ruff configuration recognizing pydantic.validator and pydantic.root_validator as class-method decorators, fixing naming linting for validator methods (canonical/starbase#134, 3d09653).
qwen/qwen3.6-35b-a3b — — Merged into main. Updated ruff configuration to correctly recognize pydantic.validator decorators on class methods. Approved by reviewer, passed CI, and maintained 100% coverage.
qwen3.6-35b-a3b-mtp-q6 — — Merged into main. Updated ruff configuration to recognize pydantic.validator decorators on class methods. Code coverage remains at 100%.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1309 style: add pydantic.validator as a classmethod decorator charmcraft merged Merged PR #1309 as commit cabaf385, adding classmethod handling for Pydantic validators in four files.
70%