← Back to issue list

Remove line length checks from CI linters

View original Github issue

Metadata

Project
starbase
Number
#207
Type
issue
State
closed
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Line-length policy moved to EditorConfig in merged PR #221 (1d72f49); merged PR #453 (ec0cf32) later removed the docs linter’s remaining line-length check.

Resolution: closed resolved

Reason: PR #221 merged as 1d72f49 and explicitly fixed #207 by updating line-length configuration and moving enforcement to EditorConfig. PR #453 later merged as ec0cf32, removing the documentation linter check.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Discussed in an in-person sync: We still want to keep line endings to a sane length, but we can do that through editorconfig. However, sometimes keeping with the letter of that defeats the spirit of the line length improving readability. See: https://github.com/canonical/starbase/pull/203 Actions to take from this: * Enable `max_line_length = 80` for markdown and rst files in editorconfig * Keep (and enable where available but not used) max line lengths in any auto-formatters * Determine at engineering sprint what our appropriate linter line length is.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Line-length policy moved to EditorConfig in merged PR #221 (1d72f49); merged PR #453 (ec0cf32) later removed the docs linter’s remaining line-length check.
stealth/space-bunny-alpha — closed resolved Partially resolved: #221 (1d72f49) updated line-length configuration, while #453 (ec0cf32) removed the docs linter check. RST was set to 88, but CI enforcement was not fully removed.
qwen/qwen3.6-35b-a3b — — Closed without fully removing CI linter checks. RST line length was set to 88, and readme badges were adjusted to use txt inclusion. Line length enforcement was partially shifted to editorconfig rather than fully removed.
qwen/qwen3.6-35b-a3b — — Closed. RST line length was set to 88 and README badges were updated to use txt inclusion. CI linter line checks were not fully removed; editorconfig now handles formatting standards while linters retain partial limits.
qwen3.6-35b-a3b-mtp-q6 — — Closed. Rst line length limit was set to 88. Line length checks remain in auto-formatters and editorconfig rather than CI linters. Jira ticket CRAFT-3002 created for tracking.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/starbase#221 (confidence 99%)

    Merged commit 1d72f49 explicitly fixes #207 and moves line-length guidance to EditorConfig.

  • Likely Fixed By: canonical/starbase#453 (confidence 98%)

    Merged commit ec0cf32 removed the remaining documentation linter line-length check.

Related issues

Issue Project State Summary Similarity
#453 build(docs): remove line length check from linter starbase merged Merged PR #453 removed the documentation line-length check from the linter in commit ec0cf32.
76%
#5832 build(docs): remove line length check from linter snapcraft merged Merged PR #5832 in commit a634d1f08, removing the documentation line-length check from the linter in a one-line configuration change.
75%
#2466 build(docs): remove line length check from linter charmcraft merged Merged PR charmcraft#2466 as commit 2acf69d1, removing the documentation line-length check from the linter in a one-line configuration change.
72%
#221 chore: update line length configuration starbase merged Merged as commit 1d72f49, updating line-length configuration and moving enforcement to EditorConfig; PR #221 fixes #207.
71%