← Back to issue list

Makefile/CI: Unfold groups if they failed

View original Github issue

Metadata

Project
starbase
Number
#340
Type
issue
State
open
Author
lengau
Labels
—
Created
Updated
Closed
—

Current evaluation

Requests that Makefile CI log groups in common.mk be left unfolded when a recipe fails. Still open and unimplemented; the author notes it is blocked by upstream GitHub community discussion #39411 (no conditional folding).

Suggested action: keep open

Reason: The request is valid and precisely stated ("If a group fails, it shouldn't be folded"), authored by a maintainer, and still unimplemented: common.mk at HEAD wraps 17 recipe bodies in `::group::`/`::endgroup::` (lines 53-392) under `.ONESHELL:` with `.SHELLFLAGS = -ec`, so the closing `echo ::endgroup::` is skipped when a command fails, and a grep for `trap` in the repo returns no matches, confirming no error-path workaround exists yet. The body explicitly states it is "Blocked by https://github.com/orgs/community/discussions/39411", an external upstream limitation, which caps impact and actionability: downstream of 20+ Starcraft repos this is a log-readability DX improvement rather than a functional break, and the fix approach is undecided without upstream support.

Evaluated by: mr-cal-bot

Impact: 32 Quick Win: 8 Complexity: 50 Confidence: 76 Actionability: 50

Issue body

If a group fails, it shouldn't be folded. Blocked by https://github.com/orgs/community/discussions/39411

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha
Impact: 32
Quick Win: 8
Complexity: 50
Confidence: 76
Actionability: 50
keep open Requests that Makefile CI log groups in common.mk be left unfolded when a recipe fails. Still open and unimplemented; the author notes it is blocked by upstream GitHub community discussion #39411 (no conditional folding).
qwen/qwen3.6-35b-a3b
Impact: 20
Quick Win: 5
Complexity: 10
Confidence: 60
Actionability: 30
needs triage Feature request to keep CI groups unfolded when they fail, currently blocked by GitHub community discussion #39411
qwen/qwen3.8-27b
Impact: 20
Quick Win: 14
Staleness: 75
Complexity: 30
Confidence: 60
Support Request: 0
keep open CI/Makefile improvement: failed log groups should be unfolded in CI output for easier debugging. Self-filed by a maintainer, no labels or comments, blocked by a GitHub feature request (community discussion 39411); inactive ~19 months.
qwen/qwen3.6-35b-a3b
Staleness: 95
Complexity: 15
Confidence: 85
Support Request: 5
close stale CI workflow groups collapsed on failure. Blocked by external GitHub discussion. No activity or maintainer response for 537 days.
qwen3.6-35b-a3b-mtp-q6
Staleness: 90
Complexity: 20
Confidence: 75
Support Request: 0
needs triage CI enhancement to unfold failed group logs instead of folding them. Currently inactive for over 14 months and blocked by an external GitHub discussion.

Update history

No update history recorded yet.

Related work

  • Blocked By: community#39411 (confidence 90%)

    Explicitly cited in the issue body as the blocker (a GitHub community discussion requesting conditional log-group folding), not an issue in a tracked project.

  • Related To: starbase#292 (confidence 80%)

    Commit 8095ce8 "feat(common.mk): group linters in CI (#292)" is the change that introduced the ::group::/::endgroup:: wrapping this issue asks to make failure-aware.

  • Related To: starbase#563 (confidence 70%)

    Commit 544b986 "fix(build): collapse docs-install logs under parent targets (#563)" is later work on the same CI log-folding behaviour in common.mk, without addressing failed-group unfolding.

Related issues

No related issues found above the similarity threshold.