← Back to issue list

CI to check pre-commit updates from renovate

View original Github issue

Metadata

Project
starbase
Number
#352
Type
issue
State
open
Author
lengau
Labels
—
Created
Updated
Closed
—

Current evaluation

Maintainer request to add a CI check running `pre-commit run --all-files` so Renovate's pre-commit hook bumps can't break things. Still unimplemented: only an automated research comment; common.mk's format-pre-commit still just runs `pre-commit run`.

Suggested action: keep open

Reason: The request is valid and still unmet: repo inspection confirms the only pre-commit invocation is `uv tool run pre-commit run` (common.mk:114, format-pre-commit), and a git log search for "pre-commit run --all-files" across starbase returns no commits, so nothing implements it. The `lint` job delegates to canonical/starflow's lint-python.yaml (qa.yaml:35) and runs linters directly, bypassing the pre-commit framework. Scope is tiny and specific (one command plus a make target/CI step); the only mild open question is whether the job belongs in the shared starflow workflow or locally, which keeps actionability slightly below turnkey.

Evaluated by: mr-cal-bot

Impact: 30 Quick Win: 18 Complexity: 25 Confidence: 86 Actionability: 80

Issue body

When renovate updates the pre-commit config, we should run `pre-commit run --all-files` in CI to ensure it doesn't break things.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha
Impact: 30
Quick Win: 18
Complexity: 25
Confidence: 86
Actionability: 80
keep open Maintainer request to add a CI check running `pre-commit run --all-files` so Renovate's pre-commit hook bumps can't break things. Still unimplemented: only an automated research comment; common.mk's format-pre-commit still just runs `pre-commit run`.
qwen/qwen3.6-35b-a3b
Impact: 30
Quick Win: 19
Complexity: 20
Confidence: 70
Actionability: 80
needs triage Feature request to add CI job running `pre-commit run --all-files` when Renovate updates pre-commit config in starcraft
qwen/qwen3.8-27b
Impact: 35
Quick Win: 21
Staleness: 45
Complexity: 40
Confidence: 65
Support Request: 10
keep open CI should run pre-commit run --all-files when renovate updates .pre-commit-config.yaml. Issue is 565 days old but had a Copilot research comment 19 days ago confirming the gap still exists. A prior attempt to add --all-files was walked back (commit 2443e63), so the solution needs rethinking.
qwen/qwen3.6-35b-a3b
Staleness: 85
Complexity: 20
Confidence: 85
Support Request: 10
needs triage Request to add a CI job running pre-commit on Renovate updates, as current CI bypasses the framework. Awaiting maintainer triage.
qwen/qwen3.6-35b-a3b
Staleness: 95
Complexity: 15
Confidence: 85
Support Request: 5
needs triage Request to add a CI job running pre-commit checks after Renovate updates. Unlabelled, unassessed, and inactive for over 14 months with zero maintainer interaction.
qwen3.6-35b-a3b-mtp-q6
Staleness: 90
Complexity: 15
Confidence: 80
Support Request: 5
needs triage Request to add a CI step that runs pre-commit checks when Renovate updates the pre-commit configuration. The issue remains unlabelled and unaddressed after over a year.

Update history

Date Change
updated

Related work

  • Related To: canonical/starbase#242 (confidence 65%)

    Merged PR 'ci(renovate): enable pre-commit support' that enabled the Renovate pre-commit dependency manager — the source of the hook bumps this issue wants CI to validate.

Related issues

Issue Project State Summary Similarity
#242 ci(renovate): enable pre-commit support starbase merged Merged PR #242 enabled Renovate support for pre-commit hooks in CI configuration, allowing hook dependencies to be updated automatically (commit 6b7fa70).
77%
#400 ci(renovate): run tests on renovate branches craft-providers merged Merged #400 as 91fc208, adding renovate/* branches to CI triggers so dependency-update branches run tests before PR creation.
70%
#185 ci(renovate): fix pre-commit dependency manager starbase merged Renovate’s pre-commit dependency manager was corrected and merged in #185 via commit 5b1422b, restoring automated pre-commit updates.
70%