← Back to issue list

fix: walk back pre-commit all-files

View original Github issue

Metadata

Project
starbase
Number
#413
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #413 in commit 2443e63, removing --all-files from pre-commit formatting so its scope matches make format.

Resolution: closed resolved

Reason: The one-line fix was merged as commit 2443e63 with all CI checks passing. It removes the broader --all-files behavior from pre-commit formatting.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Using `--all-files` for pre-commit format affects more files than `make format` would otherwise do. - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? ---

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #413 in commit 2443e63, removing --all-files from pre-commit formatting so its scope matches make format.
stealth/space-bunny-alpha — closed resolved Merged canonical/starbase#413, removing --all-files from pre-commit formatting so it matches the scope of make format. All CI checks passed.
qwen/qwen3.6-35b-a3b — — Merged a fix to remove --all-files from pre-commit formatting to align with make format scope. Approved by two reviewers, passed all CI checks, and merged with a single-line change.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix to remove the --all-files flag from pre-commit. This aligns the hook with make format by preventing unintended formatting of extra files.

Update history

No update history recorded yet.

Related work

  • Caused By: canonical/starbase#405 (confidence 90%)

    Commit 18e50d3 introduced pre-commit auto-formatting with the --all-files behavior that #413 walked back.

Related issues

Issue Project State Summary Similarity
#405 style: add pre-commit to auto-formatting starbase merged Merged PR #405 added pre-commit auto-formatting in commit 18e50d3, updating two files and passing all CI checks.
72%