← Back to issue list

fix: remove conflicting syncs during setup

View original Github issue

Metadata

Project
starbase
Number
#419
Type
pull request
State
merged
Author
jahn-junior
Labels
—
Created
Updated
Closed

Current evaluation

Merged to fix conflicting uv sync calls during setup. Introduces intermediate _setup-* targets to install requirements before syncing. Approved by two reviewers, passed all CI checks, and successfully merged.

Suggested action: —

No scores available.

Issue body

- [X] Have you followed the guidelines for contributing? - [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [X] Have you successfully run `make lint && make test`? --- Prevents conflicting invocations of `uv sync` when running `make setup`. See https://github.com/canonical/starbase/pull/418#issuecomment-3112214042 for context. * Add intermediate `_setup-*` targets that install requirements without invoking `uv sync` * Update `setup-*` targets to call said targets and invoke `uv sync`

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged to fix conflicting uv sync calls during setup. Introduces intermediate _setup-* targets to install requirements before syncing. Approved by two reviewers, passed all CI checks, and successfully merged.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix that prevents conflicting uv sync invocations during make setup. The change introduces intermediate _setup-* targets to install requirements separately, then calls uv sync in the main setup-* targets to ensure sequential execution.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#6133 build: fix docs-install target snapcraft merged Merged a fix for the docs-install Makefile target that resolved redundant dependency installation. The change removes an extra uv sync call, ensuring docs targets work after make setup. Approved by reviewers and passed CI.
77%
#418 fix: install system packages during setup starbase merged Merged after approval and passing CI checks. The update configures make setup to run all setup targets, ensuring system packages are installed. A reviewer flagged potential dependency conflicts, but the changes were successfully integrated.
71%