← Back to issue list

ci: do not double-lint renovate PRs

View original Github issue

Metadata

Project
starbase
Number
#581
Type
pull request
State
merged
Author
bepri
Labels
—
Created
Updated
Closed

Current evaluation

Merged a CI fix preventing lint workflows from running twice on Renovate PRs. The change removes the redundant renovate/* trigger, eliminating duplicate executions and reruns. Approved and passed all checks.

Suggested action: —

No scores available.

Issue body

The combination of `renovate/*` and `pull_request:` as triggers meant that Renovate PRs would trigger the lint workflow twice. The main (hypothetical) benefit here would be that Renovate would potentially not create bumping PRs if there were linting errors, but we'd often not want that behavior (e.g., Ruff updates) and it didn't seem to actually do this anyways?? As it stands, it just causes me to have to rerun two workflows instead of only one workflow when there's a flaky failure in our link checker on a Renovate PR. --- - [ ] I've followed the [contribution guidelines](https://github.com/canonical/starbase/blob/main/CONTRIBUTING.md). - [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged a CI fix preventing lint workflows from running twice on Renovate PRs. The change removes the redundant renovate/* trigger, eliminating duplicate executions and reruns. Approved and passed all checks.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 5
Confidence: 95
needs review Fixes duplicate lint workflow triggers on Renovate PRs by removing a redundant trigger. All CI checks pass and the change has maintainer approval.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 5
Confidence: 95
needs review Fixes CI workflow to prevent Renovate PRs from triggering the lint job twice by removing overlapping triggers. All CI checks pass and the change has one maintainer approval.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 5
Confidence: 90
needs review Fixes CI workflow to prevent Renovate PRs from triggering lint checks twice by removing overlapping triggers. All CI checks pass, awaiting maintainer review.

Update history

Date Change
updated
updated
created

Related issues

Issue Project State Summary Similarity
#183 chore: make pre-commit linters use lint group for renovate starbase merged Merged a chore PR configuring pre-commit linters to use the lint group for Renovate. The single-file change (+3/-3 lines) passed CI, received one approval, and was successfully integrated.
76%
#338 ci: fix renovate scheduling rockcraft merged Merged a fix for a Renovate scheduling configuration error. The maintainer corrected a linter-missed mistake in 2 lines across 1 file. The change received approval, passed CI checks, and was successfully merged.
76%
#98 ci: fix renovate schedule craft-archives merged Merged to main. Fixed the Renovate CI schedule by updating two lines in a single configuration file. The change received approval, passed CI checks, and maintained existing code coverage.
75%
#127 ci(renovate): run tests on renovate branches starbase merged Merged into main after reviewer approval and passing CI checks. Configured the CI pipeline to automatically execute tests on Renovate branches, ensuring dependency updates are validated without impacting overall code coverage.
75%
#523 ci: fix renovate scheduling craft-parts merged Merged after approval from two reviewers and passing CI checks. The change fixed Renovate scheduling configuration in the CI pipeline with a minimal three-line update across one file.
75%
#242 ci(renovate): enable pre-commit support starbase merged Merged after single reviewer approval. Enables Renovate pre-commit manager support via a single file change (+2/-12 lines). CI checks passed successfully.
74%
#94 ci: rebuild artifacts after renovate updates craft-actions merged Merged. Adds a CI workflow to recompile JavaScript after Renovate updates Node dependencies. Approved by two reviewers, passed all checks, and modified 2 files. Targets only Renovate PRs to reduce commit noise.
74%
#168 ci: fix renovate schedule craft-cli merged Merged to main after reviewer approval. The change fixes the Renovate CI schedule configuration with a two-line update. Code coverage remains unchanged.
73%
#126 ci(renovate): allow more branches starbase merged Merged a configuration update to explicitly set Renovate's branchConcurrentLimit, resolving an implicit setting that blocked automerges and PR creation. Approved by reviewers, passed CI, and modified one file without affecting coverage.
73%
#215 ci: remove deprecated renovate config options starbase merged Merged update removing deprecated Renovate configuration options from CI. Approved by two reviewers, passed checks, and modified two files.
73%