← Back to issue list

ci: do not double-lint renovate PRs

View original Github issue

Metadata

Project
starbase
Number
#581
Type
pull request
State
merged
Author
bepri
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #581 by bepri drops the redundant 'renovate/*' trigger from the lint workflow so Renovate PRs no longer run linting twice (-1 line in the workflow file).

Resolution: closed resolved

Reason: The pull request itself was merged into main (approved, all CI checks passing) with a single-line deletion removing the duplicate 'renovate/*' pull_request trigger from the lint workflow, so Renovate PRs now trigger lint once.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The combination of `renovate/*` and `pull_request:` as triggers meant that Renovate PRs would trigger the lint workflow twice. The main (hypothetical) benefit here would be that Renovate would potentially not create bumping PRs if there were linting errors, but we'd often not want that behavior (e.g., Ruff updates) and it didn't seem to actually do this anyways?? As it stands, it just causes me to have to rerun two workflows instead of only one workflow when there's a flaky failure in our link checker on a Renovate PR. --- - [ ] I've followed the [contribution guidelines](https://github.com/canonical/starbase/blob/main/CONTRIBUTING.md). - [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #581 by bepri drops the redundant 'renovate/*' trigger from the lint workflow so Renovate PRs no longer run linting twice (-1 line in the workflow file).
stealth/space-bunny-alpha — closed resolved Merged PR #581 by maintainer bepri removed the redundant `renovate/*` trigger from the lint workflow, which alongside `pull_request:` caused Renovate PRs to run linting twice (1 file, -1 line).
stealth/space-bunny-alpha — closed resolved Merged canonical/starbase#581, removing the redundant renovate/* trigger so Renovate PRs run the lint workflow once instead of twice.
qwen/qwen3.6-35b-a3b — — Merged a CI fix preventing lint workflows from running twice on Renovate PRs. The change removes the redundant renovate/* trigger, eliminating duplicate executions and reruns. Approved and passed all checks.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 5
Confidence: 95
needs review Fixes duplicate lint workflow triggers on Renovate PRs by removing a redundant trigger. All CI checks pass and the change has maintainer approval.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 5
Confidence: 95
needs review Fixes CI workflow to prevent Renovate PRs from triggering the lint job twice by removing overlapping triggers. All CI checks pass and the change has one maintainer approval.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 5
Confidence: 90
needs review Fixes CI workflow to prevent Renovate PRs from triggering lint checks twice by removing overlapping triggers. All CI checks pass, awaiting maintainer review.

Update history

Date Change
updated
updated
created

Related issues

Issue Project State Summary Similarity
#183 chore: make pre-commit linters use lint group for renovate starbase merged Merged PR #183 in commit f6db1eb, updating pre-commit configuration so Renovate-managed linters use the lint dependency group.
71%
#215 ci: remove deprecated renovate config options starbase merged Merged CI cleanup PR #215 (commit 77ce088) dropped deprecated options from .github/renovate.json5; approved by 2 reviewers with no CI failures. Config later superseded by #260/#281.
71%