← Back to issue list

Version test rejects dirty suffix in version strings

View original Github issue

Metadata

Project
starbase
Number
#589
Type
issue
State
open
Author
lengaubot
Labels
—
Created
Updated
Closed
—

Current evaluation

Version test test_version_with_tags rejected the .dYYYYMMDD dirty suffix; the regex at current HEAD in tests/integration/test_version.py already ends with (\.d[0-9]*)?, so the fix appears already in place.

Suggested action: close resolved

Reason: Reading tests/integration/test_version.py at the pinned HEAD shows test_version_with_tags already asserts re.fullmatch(r"\d+\.\d+\.\d+(\.post\d+\+g[0-9a-f]+)?(\.d[0-9]*)?", version), with a matching comment documenting 'X.Y.Z.post<commits since tag>+g<hash>.d<%Y%m%d>' — the reported version 7.2.0.post165+g2c9fc684.d20260818 satisfies it. File history shows 8c64fc4 'meta: add dirty flag to versioning scheme (#96)' as the commit introducing dirty-flag handling. Confidence is capped at 76 because grep_repo/git_log_search and read_file at alternate refs all returned 'No pinned SHA available' errors, so I could not run a pickaxe search to pinpoint which commit added (\.d[0-9]*)? or verify it predates the 45-day-old report; a maintainer should confirm the attribution before closing.

Evaluated by: mr-cal-bot

Impact: 32 Quick Win: 27 Complexity: 6 Confidence: 76 Actionability: 90

Issue body

`test_version_with_tags` in `tests/integration/test_version.py` rejects version strings with the dirty suffix, so a merge that carries a dirty working tree fails `make test-fast`. Observed failure: - expected regex: `\\d+\\.\\d+\\.\\d+(\\.post\\d+\\+g[0-9a-f]+)?` - actual version: `7.2.0.post165+g2c9fc684.d20260818` The Craft Application repo has already fixed this in PR [#864](https://github.com/canonical/craft-application/pull/864) (`fix(test): fix version test`). The Starbase-side test should accept the `.dYYYYMMDD` dirty suffix as well.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha
Impact: 32
Quick Win: 27
Complexity: 6
Confidence: 76
Actionability: 90
close resolved Version test test_version_with_tags rejected the .dYYYYMMDD dirty suffix; the regex at current HEAD in tests/integration/test_version.py already ends with (\.d[0-9]*)?, so the fix appears already in place.
stealth/space-bunny-alpha
Impact: 30
Quick Win: 23
Complexity: 10
Confidence: 90
Actionability: 85
close resolved test_version_with_tags regex lacked the .d<date> dirty suffix group, so dirty merges failed make test-fast; already fixed at HEAD via 8c64fc4 (PR #96), issue still open with no comments.
stealth/space-bunny-alpha
Impact: 27
Quick Win: 18
Complexity: 6
Confidence: 80
Actionability: 72
close resolved Dirty-suffix (.d<date>) version strings failed test_version_with_tags; the regex in tests/integration/test_version.py at current HEAD already includes the optional dirty group, so the reported failure appears already resolved (commit 8c64fc4, PR #96).
stealth/space-bunny-alpha
Impact: 27
Quick Win: 24
Complexity: 3
Confidence: 88
Actionability: 92
needs triage Reported dirty-suffix version-test failure appears patched in the current test regex, but no Starbase commit or PR is identified to document its resolution.
qwen3.6-35b-a3b-mtp-q6
Impact: 40
Quick Win: 34
Staleness: 40
Complexity: 15
Confidence: 65
Support Request: 10
needs triage test_version_with_tags rejects dirty suffix in version strings, causing CI failures on dirty working trees. Untriaged, no maintainer response.
qwen/qwen3.6-35b-a3b
Staleness: 0
Complexity: 10
Confidence: 90
Support Request: 0
needs triage Integration test fails on version strings with the .dYYYYMMDD dirty suffix. Unlabelled, no maintainer response yet.

Update history

Date Change
created

Related work

  • Related To: canonical/craft-application#864 (confidence 85%)

    Explicitly cited in the issue body as the already-landed sibling fix ('fix(test): fix version test') for the same dirty-suffix regex problem.

Related issues

No related issues found above the similarity threshold.