← Back to issue list

meta: use snapcraft's versioning scheme

View original Github issue

Metadata

Project
starbase
Number
#86
Type
pull request
State
merged
Author
mr-cal
Labels
Created
Updated
Closed

Current evaluation

Merged after two approvals and passing CI. Updates the versioning scheme to match snapcraft's using setuptools-scm, adding 78 lines across two files with zero coverage impact.

Suggested action:

No scores available.

Issue body

- [X] Have you followed the guidelines for contributing? - [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [X] Have you successfully run `tox`? ----- The versioning is now a close match to [snapcraft's versioning scheme](https://github.com/snapcore/snapcraft/blob/6b94548db638ddb17acf49b7340a2b801a1ab4e7/tools/version.py#L25-L30) using [setuptools-scm](https://github.com/pypa/setuptools_scm/tree/main). Getting it any closer will require creating a custom [Version](https://github.com/pypa/packaging/blob/63f4cfe679fb3d9322e56d8569207ecff4735238/src/packaging/version.py#L157) class. (CRAFT-1794)

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after two approvals and passing CI. Updates the versioning scheme to match snapcraft's using setuptools-scm, adding 78 lines across two files with zero coverage impact.
qwen3.6-35b-a3b-mtp-q6 Merged into main, adopting snapcraft's versioning scheme via setuptools-scm. The update aligns version generation with snapcraft, maintains 100% code coverage, and addresses CRAFT-1794.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#58 changes to snapcraft.yaml, and version, for 0.2.0 charmcraft merged Merged following single reviewer approval. Updated snapcraft.yaml and bumped project version to 0.2.0 across two files, adding 107 lines and removing 9.
78%
#2278 snap: pull early snapcraft merged Merged a one-line change to execute snapcraftctl pull before snapcraftctl set-version. Approved by one reviewer, passed CI checks, and modified a single file.
75%
#776 Updated the contents of the snapcraft init template snapcraft merged Merged update to the snapcraft init template. The maintainer modified 44 lines across three files to align with LP #1620428. Changes were integrated after a retest request, with no blocking CI failures or unresolved review comments.
75%
#204 Update snapcraft.yaml charmcraft merged Merged updates to snapcraft.yaml by markshuttle. Applied text changes for snapcraft.io and snap users, approved by two reviewers with zero unresolved comments. Diff added 18 lines and removed 14 across one file.
74%
#49 packages: add snap package support craft-parts merged Merged after implementing snap download and installation for stage and build snaps. Approved by two reviewers, passed CI, and added 1,072 lines across five files. Follows snapcraft conventions with future refactoring planned.
74%
#2238 reporting: record the released version for errors snapcraft merged Merged changes to record the released snapcraft version in error reports. Approved by reviewer, passed CI checks, and integrated with a 13-line update.
74%
#894 store: send snapcraft version in a header snapcraft merged Merged. The snapcraft version is now sent in a request header, resolving Launchpad bug #1640501. Approved by one reviewer with zero unresolved comments. Changes modify four files, adding 21 lines and removing 23.
73%
#299 fix(remote-build): minor edge cases found with snapcraft craft-application merged Fixed minor snapcraft edge cases in remote builds. Merged following approval by two reviewers and passing CI checks. The update modifies three files, adding 43 lines and removing 13.
73%
#3609 tests: move legacy snapcraft tests (CRAFT-728) snapcraft merged Merged following reviewer approval and passing CI. Relocated unit tests for the renamed snapcraft_legacy package to tests/legacy, modifying 313 files (+579/-564 lines).
73%
#85 test: cleanup test now that we have a new enough snapcraft snapcraft-rocks merged Merged test cleanup after upgrading to a stable snapcraft version. Removes six lines of outdated test code. Approved by one reviewer, passed all CI checks, and successfully merged.
73%