lint: fix mypy config to 'recurse'
Metadata
Current evaluation
Merged PR #94 by maintainer tigarmo changed the mypy override from module = ["starcraft"] to "starcraft.*" so typing checks cover sub-packages; merged as commit 296c5dd (still present in pyproject.toml).
Resolution: closed resolved
Reason: The PR was approved and merged into main as commit 296c5dd ("lint: fix mypy config to 'recurse' (#94)"). The resulting one-line diff is still live in the repo: pyproject.toml now has [[tool.mypy.overrides]] module = ["starcraft.*"] instead of ["starcraft"], so sub-modules are type-checked.
Evaluated by: mr-cal-bot
No scores available.
Issue body
`module = ["starcraft"]` only checks checks the `starcraft` main package, and not any sub-packages and modules.
- [ ] Have you followed the guidelines for contributing?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `tox`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #94 by maintainer tigarmo changed the mypy override from module = ["starcraft"] to "starcraft.*" so typing checks cover sub-packages; merged as commit 296c5dd (still present in pyproject.toml). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #94 changed mypy’s module setting from starcraft to starcraft,recurse, extending type checks to sub-packages and modules; merge commit 11e8230. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged into main after approval. Fixed mypy configuration to recursively check sub-packages and modules. Passed CI with no coverage changes. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main. Updated mypy configuration to recursively check sub-packages and modules instead of only the main package. Codecov reports no coverage change upon merge. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/starbase#158
(confidence 45%)
Later commit 86b756b "chore: use new mypy config `extra_checks` (#158)" further refines the same mypy configuration block, but is unrelated to this PR's outcome.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #6 tools: Configure mypy | starbase | merged | Merged #6 in commit 229ee11, adding mypy configuration across two files (+30/−1 lines). | |
| #6132 Linting breaks mypy | snapcraft | closed | Superseded by merged PR #6247 (commit 534d7dce7), which replaced mypy linting with Astral ty; the missing-mypy failure no longer applies. |