← Back to issue list

lint: fix mypy config to 'recurse'

View original Github issue

Metadata

Project
starbase
Number
#94
Type
pull request
State
merged
Author
tigarmo
Labels
Created
Updated
Closed

Current evaluation

Merged into main after approval. Fixed mypy configuration to recursively check sub-packages and modules. Passed CI with no coverage changes.

Suggested action:

No scores available.

Issue body

`module = ["starcraft"]` only checks checks the `starcraft` main package, and not any sub-packages and modules. - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged into main after approval. Fixed mypy configuration to recursively check sub-packages and modules. Passed CI with no coverage changes.
qwen3.6-35b-a3b-mtp-q6 Merged into main. Updated mypy configuration to recursively check sub-packages and modules instead of only the main package. Codecov reports no coverage change upon merge.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2738 mypy: add coverage to tests snapcraft merged Merged changes adding mypy static type checking to unit tests. Updated mypy.ini to target Python 3.6 and applied minor test fixups for successful execution. Approved by one reviewer and merged with 12 additions and 11 deletions across seven files.
73%
#856 style: update mypy and fix linting issues craft-application merged Merged after receiving approval from two reviewers and passing all CI checks. The update refreshed mypy and resolved linting issues across two files, resulting in 38 additions and 32 deletions.
72%
#6034 style: fix mypy warnings snapcraft merged Merged after approval from two reviewers. The changes resolve two mypy type-checking warnings by modifying a single file. All CI checks passed, and the fix was integrated into the main branch.
71%
#479 style: drop mypy, pyright craft-cli merged Merged after approval from two reviewers; replaces mypy and pyright with ty, passing all CI checks. The change removed 341 lines and added 17 across 8 files.
70%
#6 tools: Configure mypy starbase merged Configuring mypy was approved by one reviewer and successfully merged. The update modified two files, adding 30 lines and removing 1, to establish type checking in the project tools.
70%
#66 lint: update pylint configuration craft-store merged Merged an update to the pylint configuration, removing 627 lines of outdated settings and adding 16 lines with no functional changes. Approved by a reviewer and passed all CI checks.
70%