← Back to issue list

meta: add dirty flag to versioning scheme

View original Github issue

Metadata

Project
starbase
Number
#96
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged #96 as commit 8c64fc4, adding a dirty-version flag to align with setuptools_scm and relocating an integration test.

Resolution: closed resolved

Reason: PR #96 was approved and merged as commit 8c64fc4. The merged change marks versions as dirty when the working tree is dirty and moves the integration test.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [X] Have you followed the guidelines for contributing? - [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [X] Have you successfully run `tox`? ----- Adds a dirty flag to the version when the working dir is dirty. This functionality was already part of `setuptool_scm`. I had previously removed it to keep aligned with [snapcraft's scheme](https://github.com/snapcore/snapcraft/blob/40136ea9b59351e4f9f1fbed8c4d8c0db873c488/tools/version.py#L24). After an offline discussion, I think it's better to align with `setuptools_scm`. Also moves the integration test up a directory.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #96 as commit 8c64fc4, adding a dirty-version flag to align with setuptools_scm and relocating an integration test.
stealth/space-bunny-alpha — closed resolved Merged #96, adding a version dirty flag for dirty working directories to align with setuptools_scm; an integration test was also relocated.
qwen/qwen3.6-35b-a3b — — Merged. Adds a dirty flag to the versioning scheme when the working directory is dirty, aligning with setuptools_scm. Approved, passed CI, and relocated an integration test.
qwen3.6-35b-a3b-mtp-q6 — — Merged implementation adds a dirty flag to the versioning scheme for uncommitted working directories, aligning with setuptools_scm. Integration tests were relocated. Code coverage remained at 100%.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.