← Back to issue list

ci(lint-python): fail if snap install errors

View original Github issue

Metadata

Project
starflow
Number
#190
Type
pull request
State
merged
Author
mr-cal
Labels
PR: Squash
Created
Updated
Closed

Current evaluation

Merged PR fixing lint-python workflow so snap install errors are no longer swallowed by echo to GITHUB_OUTPUT; commands now run before output capture.

Resolution: closed resolved

Reason: PR #190 was merged after approval with all CI checks passing. It reorders the workflow so snap install failures propagate instead of being consumed by echo >> $GITHUB_OUTPUT.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Follow up to #188. The `echo` statement was consuming `snap install` errors, which kept the workflow from failing. Now the commands run (or error) first, and then get sent to `$GITHUB_OUTPUT`.

Evaluation history

Date Model Scores Action Summary
~deepseek/deepseek-pro-latest — closed resolved Merged PR fixing lint-python workflow so snap install errors are no longer swallowed by echo to GITHUB_OUTPUT; commands now run before output capture.
stealth/space-bunny-alpha
Impact: 30
Quick Win: 22
Complexity: 12
Confidence: 87
Actionability: 84
needs review Fixes lint-python workflow so `snap install` errors are no longer swallowed by `echo ... >> $GITHUB_OUTPUT`; commands now run before output capture. Approved, all CI checks passing; follow-up to merged #188.
qwen/qwen3.8-27b
Impact: 20
Quick Win: 15
Complexity: 5
Confidence: 75
Actionability: 80
needs review CI fix in the lint-python workflow: reorders commands so snap install errors propagate and fail the job instead of being swallowed by an echo pipe, with output still written to $GITHUB_OUTPUT. Small +4/-1 diff, all CI checks passing, pending review.

Update history

Date Change
merged
updated
updated
updated
updated
updated
created

Related work

  • Related To: canonical/starflow#188 (confidence 95%)

    Follow-up to PR #188, which introduced the lint-python workflow change whose echo statement was hiding snap install errors.

Related issues

No related issues found above the similarity threshold.