← Back to issue list

chore(deps): update dependency cryptography to v39 [security]

View original Github issue

Metadata

Project
charmcraft
Number
#1019
Type
pull request
State
closed
Author
renovate[bot]
Labels
β€”
Created
Updated
Closed

Current evaluation

Renovate PR #1019 (cryptography 3.4.8 -> 39.0.1) was closed unmerged by lengau on 2023-02-15 as superseded by canonical/charmcraft#1024, which merged the same v39.0 bump (commit 96f6a183) and added Rust build deps to snapcraft.yaml.

Resolution: closed superseded

Reason: Maintainer lengau closed the PR unmerged stating "Closing this as it's superceded by #1024"; #1024 was merged at commit 96f6a183, bumping cryptography to 39.0 and adding the required Rust build dependencies to snap/snapcraft.yaml, so the same upgrade landed via the replacement PR.

Evaluated by: mr-cal-bot

No scores available.

Issue body

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [cryptography](https://togithub.com/pyca/cryptography) ([changelog](https://cryptography.io/en/latest/changelog/)) | `==3.4.8` -> `==39.0.1` | [![age](https://badges.renovateapi.com/packages/pypi/cryptography/39.0.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/cryptography/39.0.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/cryptography/39.0.1/compatibility-slim/3.4.8)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/cryptography/39.0.1/confidence-slim/3.4.8)](https://docs.renovatebot.com/merge-confidence/) | ### GitHub Vulnerability Alerts #### [CVE-2023-23931](https://togithub.com/pyca/cryptography/security/advisories/GHSA-w7pp-m8wf-vj6r) Previously, `Cipher.update_into` would accept Python objects which implement the buffer protocol, but provide only immutable buffers: ```pycon >>> outbuf = b"\x00" * 32 >>> c = ciphers.Cipher(AES(b"\x00" * 32), modes.ECB()).encryptor() >>> c.update_into(b"\x00" * 16, outbuf) 16 >>> outbuf b'\xdc\x95\xc0x\xa2@&#8203;\x89\x89\xadH\xa2\x14\x92\x84 \x87\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00' ``` This would allow immutable objects (such as `bytes`) to be mutated, thus violating fundamental rules of Python. This is a soundness bug -- it allows programmers to misuse an API, it cannot be exploited by attacker controlled data alone. This now correctly raises an exception. This issue has been present since `update_into` was originally introduced in cryptography 1.8. #### [CVE-2023-0286](https://togithub.com/pyca/cryptography/security/advisories/GHSA-x4qr-2fvf-3mr5) pyca/cryptography's wheels include a statically linked copy of OpenSSL. The versions of OpenSSL included in cryptography 0.8.1-39.0.0 are vulnerable to a security issue. More details about the vulnerabilities themselves can be found in https://www.openssl.org/news/secadv/20221213.txt and https://www.openssl.org/news/secadv/20230207.txt. If you are building cryptography source ("sdist") then you are responsible for upgrading your copy of OpenSSL. Only users installing from wheels built by the cryptography project (i.e., those distributed on PyPI) need to update their cryptography versions. --- ### Release Notes <details> <summary>pyca/cryptography</summary> ### [`v39.0.1`](https://togithub.com/pyca/cryptography/compare/39.0.0...39.0.1) [Compare Source](https://togithub.com/pyca/cryptography/compare/39.0.0...39.0.1) ### [`v39.0.0`](https://togithub.com/pyca/cryptography/compare/38.0.4...39.0.0) [Compare Source](https://togithub.com/pyca/cryptography/compare/38.0.4...39.0.0) ### [`v38.0.4`](https://togithub.com/pyca/cryptography/compare/38.0.3...38.0.4) [Compare Source](https://togithub.com/pyca/cryptography/compare/38.0.3...38.0.4) ### [`v38.0.3`](https://togithub.com/pyca/cryptography/compare/38.0.2...38.0.3) [Compare Source](https://togithub.com/pyca/cryptography/compare/38.0.2...38.0.3) ### [`v38.0.2`](https://togithub.com/pyca/cryptography/compare/38.0.1...38.0.2) [Compare Source](https://togithub.com/pyca/cryptography/compare/38.0.1...38.0.2) ### [`v38.0.1`](https://togithub.com/pyca/cryptography/compare/38.0.0...38.0.1) [Compare Source](https://togithub.com/pyca/cryptography/compare/38.0.0...38.0.1) ### [`v38.0.0`](https://togithub.com/pyca/cryptography/compare/37.0.4...38.0.0) [Compare Source](https://togithub.com/pyca/cryptography/compare/37.0.4...38.0.0) ### [`v37.0.4`](https://togithub.com/pyca/cryptography/compare/37.0.3...37.0.4) [Compare Source](https://togithub.com/pyca/cryptography/compare/37.0.3...37.0.4) ### [`v37.0.3`](https://togithub.com/pyca/cryptography/compare/37.0.2...37.0.3) [Compare Source](https://togithub.com/pyca/cryptography/compare/37.0.2...37.0.3) ### [`v37.0.2`](https://togithub.com/pyca/cryptography/compare/37.0.1...37.0.2) [Compare Source](https://togithub.com/pyca/cryptography/compare/37.0.1...37.0.2) ### [`v37.0.1`](https://togithub.com/pyca/cryptography/compare/37.0.0...37.0.1) [Compare Source](https://togithub.com/pyca/cryptography/compare/37.0.0...37.0.1) ### [`v37.0.0`](https://togithub.com/pyca/cryptography/compare/36.0.2...37.0.0) [Compare Source](https://togithub.com/pyca/cryptography/compare/36.0.2...37.0.0) ### [`v36.0.2`](https://togithub.com/pyca/cryptography/compare/36.0.1...36.0.2) [Compare Source](https://togithub.com/pyca/cryptography/compare/36.0.1...36.0.2) ### [`v36.0.1`](https://togithub.com/pyca/cryptography/compare/36.0.0...36.0.1) [Compare Source](https://togithub.com/pyca/cryptography/compare/36.0.0...36.0.1) ### [`v36.0.0`](https://togithub.com/pyca/cryptography/compare/35.0.0...36.0.0) [Compare Source](https://togithub.com/pyca/cryptography/compare/35.0.0...36.0.0) ### [`v35.0.0`](https://togithub.com/pyca/cryptography/compare/3.4.8...35.0.0) [Compare Source](https://togithub.com/pyca/cryptography/compare/3.4.8...35.0.0) </details> --- ### Configuration πŸ“… **Schedule**: Branch creation - "" in timezone Etc/UTC, Automerge - "after 1 am and before 7 am" in timezone Etc/UTC. 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. β™» **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. πŸ”• **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/canonical/charmcraft). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMjQuMiIsInVwZGF0ZWRJblZlciI6IjM0LjEyNC4yIn0=-->

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha β€” closed superseded Renovate PR #1019 (cryptography 3.4.8 -> 39.0.1) was closed unmerged by lengau on 2023-02-15 as superseded by canonical/charmcraft#1024, which merged the same v39.0 bump (commit 96f6a183) and added Rust build deps to snapcraft.yaml.
stealth/space-bunny-alpha β€” closed superseded Closed unmerged in favor of canonical/charmcraft#1024, which merged as 96f6a183 and upgraded cryptography to 39.0 with required Rust dependencies.
qwen/qwen3.6-35b-a3b β€” β€” Superseded by PR #1024. The automated cryptography v39 security update was closed unmerged to prevent duplication with a newer dependency upgrade.
qwen3.6-35b-a3b-mtp-q6 β€” β€” Security update for cryptography to v39 was closed unmerged and superseded by pull request #1024. Renovate will ignore future 39.x releases for this branch.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/charmcraft#1024 (confidence 97%)

    Explicitly named by lengau in the closing comment; merged PR delivering cryptography v39.0 in commit 96f6a183 (also closed issue #991)

  • Related To: canonical/charmcraft#991 (confidence 72%)

    Issue #991 for the cryptography 39 security update was closed by the merging of #1024

  • Related To: canonical/charmcraft#992 (confidence 60%)

    Earlier attempt to make Renovate ignore cryptography, also closed unmerged, eventually overtaken by #1024

Related issues

Issue Project State Summary Similarity
#1056 chore(deps): update dependency cryptography to v39 [security] charmcraft closed Renovate's cryptography 3.4.8->39.0.1 security bump was closed unmerged; maintainer lengau pointed to #1024, which merged as commit 96f6a183 upgrading to 39.0 (plus Rust build deps) and closing #991.
91%
#978 chore(deps): update dependency cryptography to v39 charmcraft closed Renovate PR to bump cryptography 3.4.8 -> 39.0.0 was closed unmerged by lengau (2023-01-19) because cryptography 39 needs Rust >=1.48 unavailable on 18.04/20.04 armhf/arm64/ppc64el/s390x. Later redone manually and merged as #1024 (96f6a183).
90%
#1272 chore(deps): update dependency cryptography to v41.0.4 [security] charmcraft closed Renovate security bump of cryptography 41.0.3 -> 41.0.4 was closed unmerged by @lengau on 2023-09-21 (flaky store test) in favour of #1271, which landed as commit 431c7387.
86%
#1024 deps: update cryptography to v39.0 charmcraft merged PR #1024 (commit 96f6a183) merged into charmcraft, upgrading cryptography to39.0 and adding needed Rust build deps to snap/snapcraft.yaml; it fixes issue #991 after the author validated builds on all architectures.
86%
#1537 chore(deps): update dependency cryptography to v42.0.4 [security] charmcraft closed Renovate PR to bump cryptography 42.0.2->42.0.4 (CVE-2024-26130) was closed unmerged by lengau on 2024-02-22, deferred to a separate env-var change; the pin later moved to 42.0.5 via merged #1601 (545b8db5) and 42.0.8 in #1694.
85%
#1057 chore(deps): update dependency cryptography [security] - autoclosed charmcraft closed Renovate’s cryptography 3.4.8β†’39/40 update was autoclosed unmerged; PR #1119 (commit 42365b41) later merged 40.0.2β†’41.0.0, superseding it.
85%
#4033 build(deps): bump cryptography from 3.4 to 39.0.1 snapcraft closed Closed unmerged because cryptography 39.0.1 did not work on every architecture; maintainers cited canonical/charmcraft#1024, and Snapcraft later updated it in #4136 (3fd3e4c52).
84%
#4564 chore(deps): update dependency cryptography to v42 [security] snapcraft merged Renovate bumped cryptography from 41.0.7 to 42.0.2 (fixing CVE-2023-50782 and CVE-2024-0727); PR #4564 was approved and squash-merged into main as commit ac421ab96.
84%
#1164 chore(deps): update dependency cryptography to v41.0.2 [security] charmcraft merged Merged cryptography 41.0.2 security update via commit 6d9dd818, replacing 41.0.0 to address CVE-2023-38325.
83%
#4598 chore(deps): update dependency cryptography to v42.0.4 [security] snapcraft merged Merged #4598 in commit 7cfb60986, upgrading cryptography from 42.0.2 to 42.0.4 to address CVE-2024-26130.
83%