← Back to issue list

store: ensure promote-bundle succeeds if there are no applications

View original Github issue

Metadata

Project
charmcraft
Number
#1081
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1081 as e6357ccd, fixing promote-bundle to succeed when the store has no applications after prerequisite PR #1075 was merged.

Resolution: closed resolved

Reason: PR #1081 was approved and merged as commit e6357ccd. Its prerequisite, PR #1075, had already merged as 953cf5bd and separated store Spread test authentication from general CI.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Depends on #1075. Once that's merged this will be a whole lot cleaner The actual changes for this PR: https://github.com/canonical/charmcraft/pull/1081/files/82d83e4a1292c5619e66fe4a5045cd04cc828732..HEAD

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1081 as e6357ccd, fixing promote-bundle to succeed when the store has no applications after prerequisite PR #1075 was merged.
stealth/space-bunny-alpha — closed resolved PR #1081 (commit e6357ccd) merged into charmcraft, making the store promote-bundle command succeed when a bundle has no applications; it depended on merged PR #1075.
stealth/space-bunny-alpha — closed resolved Merged PR #1081, commit e6357ccd, ensuring promote-bundle succeeds when the store has no applications; depended on merged PR #1075.
qwen/qwen3.6-35b-a3b — — Merged fix ensuring promote-bundle succeeds when no applications are present. Depends on PR #1075. Approved by one reviewer with zero unresolved comments. Updated seven files (+47/-12 lines).
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix ensuring promote-bundle succeeds when no applications are present. Updates store logic to handle empty application lists gracefully, building on prior merge #1075 for cleaner implementation.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/charmcraft#1075 (confidence 99%)

    Declared dependency merged as 953cf5bd, isolating store Spread tests and their authentication requirements.

  • Related To: canonical/charmcraft#1089 (confidence 80%)

    Later follow-up merged as 0bf3cc07 to fix additional promote-bundle behavior issues.

Related issues

Issue Project State Summary Similarity
#1080 store: ensure promote-bundle succeeds if there are no applications charmcraft closed Closed unmerged in favor of #1081, which merged the no-applications promote-bundle fix and store tests as commit e6357ccd.
91%
#1089 store: fix issues with promote-bundle command charmcraft merged Merged PR #1089 as commit 0bf3cc07, fixing promote-bundle behavior and a spread test that had not properly exercised the command.
79%