← Back to issue list

store: fix issues with promote-bundle command

View original Github issue

Metadata

Project
charmcraft
Number
#1089
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1089 as commit 0bf3cc07, fixing promote-bundle behavior and a spread test that had not properly exercised the command.

Resolution: closed resolved

Reason: PR #1089 was approved and merged as commit 0bf3cc07, correcting the command and the ineffective spread test. Follow-up PR #1094 later added cosmetic command and output fixes.

Evaluated by: mr-cal-bot

No scores available.

Issue body

No new tests because this fixes breakage of a spread test that wasn't running properly

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1089 as commit 0bf3cc07, fixing promote-bundle behavior and a spread test that had not properly exercised the command.
stealth/space-bunny-alpha — closed resolved Merged #1089 as 0bf3cc07, fixing promote-bundle behavior and spread-test breakage; #1094 later added cosmetic command fixes.
qwen/qwen3.6-35b-a3b — — Merged a fix for the promote-bundle command that resolved test breakage. The update modified 5 files with 16 additions and 14 deletions. Approved by one reviewer, the changes were merged despite an unresolved comment flagging a potential lingering issue.
qwen3.6-35b-a3b-mtp-q6 — — Merged by maintainer lengau to fix promote-bundle command defects. CI failures were noted but the PR was integrated. No new tests added due to existing spread test breakage.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/charmcraft#1094 (confidence 95%)

    Merged as db5d54e8 to polish promote-bundle parameters and output after #1089.

Related issues

Issue Project State Summary Similarity
#1080 store: ensure promote-bundle succeeds if there are no applications charmcraft closed Closed unmerged in favor of #1081, which merged the no-applications promote-bundle fix and store tests as commit e6357ccd.
81%
#1081 store: ensure promote-bundle succeeds if there are no applications charmcraft merged Merged PR #1081 as e6357ccd, fixing promote-bundle to succeed when the store has no applications after prerequisite PR #1075 was merged.
79%
#1044 command: add the initial promote-bundle command charmcraft merged Merged PR #1044 as commit 82e43af7, adding the initial promote-bundle command for CRAFT-1516.
76%
#1093 ci: run the bundle promotion test charmcraft merged Merged PR #1093 after approval, enabling the bundle promotion test in CI.
75%
#1094 commands: cosmetic fixes to promote-bundle charmcraft merged Merged in db5d54e8: promote-bundle channel parameters became options, final action output was added, and a lingering upload-progress artifact was removed.
74%