← Back to issue list

store: fix issues with promote-bundle command

View original Github issue

Metadata

Project
charmcraft
Number
#1089
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged a fix for the promote-bundle command that resolved test breakage. The update modified 5 files with 16 additions and 14 deletions. Approved by one reviewer, the changes were merged despite an unresolved comment flagging a potential lingering issue.

Suggested action:

No scores available.

Issue body

No new tests because this fixes breakage of a spread test that wasn't running properly

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a fix for the promote-bundle command that resolved test breakage. The update modified 5 files with 16 additions and 14 deletions. Approved by one reviewer, the changes were merged despite an unresolved comment flagging a potential lingering issue.
qwen3.6-35b-a3b-mtp-q6 Merged by maintainer lengau to fix promote-bundle command defects. CI failures were noted but the PR was integrated. No new tests added due to existing spread test breakage.
qwen3.6-35b-a3b-mtp-q6 Merged fix for the promote-bundle command addressing store-related issues. No new tests were added to preserve a broken spread test. A maintainer flagged a lingering CI failure, but the changes were still merged.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1081 store: ensure promote-bundle succeeds if there are no applications charmcraft merged Merged fix ensuring promote-bundle succeeds when no applications are present. Depends on PR #1075. Approved by one reviewer with zero unresolved comments. Updated seven files (+47/-12 lines).
82%
#1044 command: add the initial promote-bundle command charmcraft merged Merged the initial promote-bundle command, adding 449 lines across 12 files to resolve CRAFT-1516. Approved by two reviewers and successfully integrated.
81%
#1094 commands: cosmetic fixes to promote-bundle charmcraft merged Merged cosmetic updates to the promote-bundle command. Channel parameters were converted to options, completion output was added, and an upload artifact was removed. Approved and merged despite an unrelated test failure tracked separately.
78%
#1093 ci: run the bundle promotion test charmcraft merged Merged a CI configuration update to execute the bundle promotion test. The change modified two files with seven additions and five deletions, received reviewer approval, and was successfully integrated.
77%
#1080 store: ensure promote-bundle succeeds if there are no applications charmcraft closed Superseded by PR #1081, which will handle the store tests and implement the fix. Original changes were not merged.
73%
#2226 feat: mark the "promote-bundle" command as deprecated charmcraft merged Merged after approval, this change marks the promote-bundle command as deprecated for removal in Charmcraft 4.0. Deprecation warnings were added while keeping bundle commands functional in version 3.0. Unrelated CI failures were overridden before merge.
71%
#2082 feat(store): promote command charmcraft merged Merged a promote command for channel transfers with stability constraints. Approved by three reviewers, it resolves issue 1633 and modifies 12 files with 951 additions and 67 deletions.
71%
#2561 Promote branches fix snapcraft merged Merged pull request resolving branch promotion issues. Approved by one reviewer with no unresolved comments. Modified five files (+44/-14 lines). CI passed, achieving 100% diff coverage.
71%