refactor: move some pydantic models and metafiles
Metadata
Current evaluation
Merged a refactoring change that relocated Pydantic models and metafiles to resolve circular imports. Approved by one reviewer, the update modified 29 files (+667/-520 lines) and closed CRAFT-1746.
Suggested action: —
No scores available.
Issue body
This should reduce some of the circular imports.
CRAFT-1746
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a refactoring change that relocated Pydantic models and metafiles to resolve circular imports. Approved by one reviewer, the update modified 29 files (+667/-520 lines) and closed CRAFT-1746. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged refactoring that relocates pydantic models and metafiles to reduce circular import dependencies, addressing CRAFT-1746. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged refactoring that relocated pydantic models and metafiles to eliminate circular imports, addressing CRAFT-1746. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #254 refactor: make pydantic models more idiomatic | craft-archives | open | Refactors pydantic models to be more idiomatic. All CI checks passing. No reviewers assigned or comments yet. | |
| #60 Migrate to pydantic 2 | imagecraft | merged | Merged after approval. The codebase was migrated to Pydantic V2 with updated craft libraries. Changes span 27 files (+278/-340 lines) and maintain 98% test coverage, resolving FR-8917. | |
| #776 feat: add pydantic models for all sources | craft-parts | merged | Merged to add Pydantic models for all sources, enabling JSON schema generation for parts. Approved by two reviewers, depends on #775, and updates 16 files with a net reduction of 103 lines. | |
| #401 build!: update to pydantic 2 | craft-application | merged | Merged to update the codebase to Pydantic 2. Approved by two reviewers and passed CI. The change modified 23 files (+531/-342). Initial test failures were resolved after the craft-grammar dependency received a corresponding update. | |
| #6236 refactor: migrate release models | snapcraft | merged | Merged after two approvals. Refactored Revision, Release, and Releases models from snapcraft_legacy to Pydantic, simplifying implementation. Unrelated spread test failures were noted but did not block the merge. | |
| #672 merge feature/pydantic-2 | rockcraft | merged | Merged the pydantic 2 migration branch via rebase after two approvals and passing CI. The update modified 26 files, adding 3661 lines and removing 2150, finalizing the migration and dependency updates. | |
| #5205 refactor: use craft-platforms utilities | snapcraft | merged | Merged following approval by two reviewers. Refactored the codebase to use craft-platforms utilities, resolving CRAFT-3278 and closing #4993. Net reduction of 307 lines across 20 files. | |
| #4682 refactor(app): use more code from craft-app | snapcraft | merged | Merged a refactoring update consolidating app code by leveraging more craft-app functionality. Approved by two reviewers, passed CI and coverage checks, and modified three files with a net reduction of 13 lines. | |
| #1334 refactor(parts): move craft-parts related things into their own package | charmcraft | merged | Merged a refactor that moves craft-parts components into a dedicated package. Approved by two reviewers with zero unresolved comments. The change modifies 16 files, adding 960 lines and removing 794. |