← Back to issue list

refactor: move some pydantic models and metafiles

View original Github issue

Metadata

Project
charmcraft
Number
#1117
Type
pull request
State
merged
Author
syu-w
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1117 (commit 42722834) moved selected Pydantic models and metafiles to reduce circular imports under CRAFT-1746.

Resolution: closed resolved

Reason: PR #1117 was merged into the project history as commit 42722834, completing the CRAFT-1746 refactor. The change relocated selected Pydantic models and metafiles to reduce circular imports.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This should reduce some of the circular imports. CRAFT-1746

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1117 (commit 42722834) moved selected Pydantic models and metafiles to reduce circular imports under CRAFT-1746.
stealth/space-bunny-alpha — closed resolved Refactor PR #1117 (merge commit 42722834) merged to main: moved Pydantic models and metafiles into a new charmcraft/models/ package to reduce circular imports. Tracked as CRAFT-1746; approved by a maintainer, no behaviour change.
stealth/space-bunny-alpha — closed resolved Merged PR #1117, relocating Pydantic models and metafiles to reduce circular imports; tracked as CRAFT-1746.
qwen/qwen3.6-35b-a3b — — Merged a refactoring change that relocated Pydantic models and metafiles to resolve circular imports. Approved by one reviewer, the update modified 29 files (+667/-520 lines) and closed CRAFT-1746.
qwen3.6-35b-a3b-mtp-q6 — — Merged refactoring that relocates pydantic models and metafiles to reduce circular import dependencies, addressing CRAFT-1746.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#254 refactor: make pydantic models more idiomatic craft-archives open Refactors Pydantic models to be more idiomatic (fixes #118). Small diff (+42/-23, 5 files). CI passing, but has 1 unresolved review comment with changes_requested status.
76%
#774 feat!: rework part models for pydantic 2 craft-parts closed Draft PR #774 to rework part models for Pydantic 2 was closed unmerged after being broken into smaller PRs; the lift-and-shift landed in #771, followed by #775, #776 and #778.
72%