← Back to issue list

feat!: rework part models for pydantic 2

View original Github issue

Metadata

Project
craft-parts
Number
#774
Type
pull request
State
closed
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Draft PR #774 to rework part models for Pydantic 2 was closed unmerged after being broken into smaller PRs; the lift-and-shift landed in #771, followed by #775, #776 and #778.

Resolution: closed superseded

Reason: The author (maintainer lengau) stated the draft would be broken into smaller PRs before leaving draft, and it was closed unmerged. Its goal was delivered instead by merged commit 6b155294 (#771, lift-and-shift to pydantic 2) plus follow-ups 029f1ad6 (#775), 3d880869 (#776) and 68d61fa0 (#778).

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- Requires #771 This is probably going to be broken down into smaller PRs before being taken out of draft, as there's a lot going on here.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Draft PR #774 to rework part models for Pydantic 2 was closed unmerged after being broken into smaller PRs; the lift-and-shift landed in #771, followed by #775, #776 and #778.
stealth/space-bunny-alpha — closed stale Closed unmerged as a draft; the Pydantic 2 migration was split into smaller PRs, with #771 providing the initial lift-and-shift update.
qwen/qwen3.6-35b-a3b — — Closed without merging. The draft PR to rework part models for Pydantic 2 received no reviews and was abandoned, likely superseded by smaller incremental PRs as noted by the author.
qwen3.6-35b-a3b-mtp-q6 — — Closed without merging. The Pydantic 2 model rework was abandoned, likely superseded by smaller incremental PRs as noted in the draft description. No comments or further activity occurred.

Update history

No update history recorded yet.

Related work

  • Superseded By: craft-parts#771 (confidence 95%)

    PR body says 'Requires #771'; commit 6b155294 'chore!: lift-and-shift update to pydantic 2' landed the migration.

  • Superseded By: craft-parts#775 (confidence 80%)

    Commit 029f1ad6 'chore!: restructure plugin models (#775)' continues the pydantic 2 model rework.

  • Superseded By: craft-parts#776 (confidence 80%)

    Commit 3d880869 'feat: add pydantic models for all sources (#776)' is part of the same migration series.

  • Superseded By: craft-parts#778 (confidence 80%)

    Commit 68d61fa0 'chore: pydantic 2 related cleanup (#778)' follows the same series.

Related issues

Issue Project State Summary Similarity
#1117 refactor: move some pydantic models and metafiles charmcraft merged Merged PR #1117 (commit 42722834) moved selected Pydantic models and metafiles to reduce circular imports under CRAFT-1746.
72%
#254 refactor: make pydantic models more idiomatic craft-archives open Refactors Pydantic models to be more idiomatic (fixes #118). Small diff (+42/-23, 5 files). CI passing, but has 1 unresolved review comment with changes_requested status.
71%
#776 feat: add pydantic models for all sources craft-parts merged Merged PR #776 added Pydantic models for every source, enabling whole-part JSON schema generation and building on prerequisite PR #775.
71%