← Back to issue list

Remove business logic from pack command class

View original Github issue

Metadata

Project
charmcraft
Number
#1147
Type
issue
State
closed
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Pack command business logic was moved into a service class by merged PR charmcraft#1230 (commit 55984349), resolving charmcraft#1147.

Resolution: closed resolved

Reason: PR charmcraft#1230 refactored the business logic out of the pack command class and was merged as commit 55984349.

Evaluated by: mr-cal-bot

No scores available.

Issue body

### What needs to get done The pack command should have its business logic moved into a service class. Ideally we'd do this with other commands too, but it's absolutely necessary for the pack command. ### Why it needs to get done Precursor for #1133

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Pack command business logic was moved into a service class by merged PR charmcraft#1230 (commit 55984349), resolving charmcraft#1147.
stealth/space-bunny-alpha — closed resolved Pack command business logic was moved into a service class by merged PR #1230 (commit 55984349), resolving #1147.
stealth/space-bunny-alpha — closed resolved Pack command business logic was moved into a service class by merged PR #1230 (commit 55984349), following #1229 and resolving #1147.
qwen3.6-35b-a3b-mtp-q6 — — Closed without implementation or discussion. The task to extract pack command business logic into a service class was likely superseded or abandoned, with no pull request or resolution documented.
qwen/qwen3.6-35b-a3b — — Closed without a linked resolution. The refactoring task to extract the pack command's business logic into a service class was abandoned or superseded, as no pull request or implementation details were recorded.
qwen/qwen3.6-35b-a3b — — Abandoned. Closed without linked resolution or comments. The task to extract business logic from the pack command into a service class remains unaddressed.
qwen3.6-35b-a3b-mtp-q6 — — Closed. The requested refactoring to extract pack command business logic into a service class was not implemented and appears abandoned or superseded.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: charmcraft#1230 (confidence 100%)

    Merged refactor that introduced the pack service and resolved the reported command-layer design problem.

  • Related To: charmcraft#1133 (confidence 95%)

    The issue identifies #1133 as the precursor requiring this refactor.

Related issues

Issue Project State Summary Similarity
#1230 pack: refactor business logic out of pack command class charmcraft merged Merged PR #1230 as commit 55984349, moving pack command business logic into a service and resolving #1147.
84%