← Back to issue list

pack: refactor business logic out of pack command class

View original Github issue

Metadata

Project
charmcraft
Number
#1230
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1230 as commit 55984349, moving pack command business logic into a service and resolving #1147.

Resolution: closed resolved

Reason: PR #1230 merged with two approvals and commit 55984349. Its description explicitly states that it fixes #1147 after building on #1229.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Builds on #1229 Fixes #1147

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1230 as commit 55984349, moving pack command business logic into a service and resolving #1147.
stealth/space-bunny-alpha — closed resolved Merged PR #1230 (commit 55984349), extracting pack command business logic into a service layer and fixing #1147; it built on merged PR #1229.
stealth/space-bunny-alpha — closed resolved Merged PR #1230 (commit 55984349), extracting pack command business logic and resolving #1147 after building on #1229.
qwen/qwen3.6-35b-a3b — — Merged after two reviewers approved. Refactors business logic out of the pack command class, building on #1229 and fixing #1147. Changes modify four files, adding 307 lines and removing 335.
qwen3.6-35b-a3b-mtp-q6 — — Merged a refactoring that extracts business logic from the pack command class, resolving issue #1147. The change builds upon PR #1229.

Update history

No update history recorded yet.

Related work

Related issues

Issue Project State Summary Similarity
#1147 Remove business logic from pack command class charmcraft closed Pack command business logic was moved into a service class by merged PR charmcraft#1230 (commit 55984349), resolving charmcraft#1147.
84%
#1565 cli: add the pack command snapcraft merged Merged PR #1565 added the pack CLI command, renamed from assemble, and landed in commit 87ad820b5.
71%