← Back to issue list

tools: update ruff configuration to starbase v1

View original Github issue

Metadata

Project
charmcraft
Number
#1232
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged after two reviewer approvals. Updated ruff configuration to starbase v1 across 64 files (+598/-525 lines). Changes resolved a circular dependency and streamlined tooling.

Suggested action:

No scores available.

Issue body

Broken into commits for ease of reading.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after two reviewer approvals. Updated ruff configuration to starbase v1 across 64 files (+598/-525 lines). Changes resolved a circular dependency and streamlined tooling.
qwen3.6-35b-a3b-mtp-q6 Merged an update to the ruff configuration for starbase v1. Changes were split into multiple commits for readability. The maintainer resolved a circular dependency by restructuring the implementation.
qwen3.6-35b-a3b-mtp-q6 Merged the ruff configuration update to starbase v1. The maintainer split changes into separate commits for readability and adjusted the setup to avoid a circular dependency.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#4816 starbase ruff snapcraft closed Abandoned without merge. The pull request updated ruff configuration, removed isort, and applied autofixes across 125 files.
80%
#263 tools: add ruff config rockcraft merged Merged. Added ruff configuration and a test-ruff target to the Makefile. Approved by three reviewers, introducing 89 lines across three files. Linting errors were noted for correction in a separate pull request.
79%
#2074 style: update to ruff 0.9.0 formatting charmcraft merged Merged to align code formatting with ruff 0.9.0 linting rules. Approved by two reviewers and passed CI. One change was noted for upstreaming to starbase instead of applying it locally.
79%
#588 chore: use the latest ruff config from starbase craft-application merged Merged an update to the ruff configuration using the latest starbase settings. Approved by two reviewers across 86 files, supporting the craft-application migration to starflow.
78%
#415 style: fix ruff 0.16 warning craft-store merged Merged after two approvals and passing CI. Resolved a ruff 0.16 warning by adding an ignore directive copied from Starbase. The change added a single line to one file.
76%
#1517 build: update ruff settings charmcraft merged Merged update to ruff configuration settings. The one-file build adjustment received approval from two reviewers and was integrated without comments or CI issues.
75%
#581 chore(linter): ruff auto fix base on starbase config craft-parts merged Merged automated ruff fixes applying the starbase config across 156 files. Adjusts formatting and import order, with tweaks for trailing commas and ignored rules. Approved by three reviewers and depends on PR #580.
75%
#580 style(ruff): fix linting issues from ruff update craft-application merged Merged after approval by three reviewers. Resolves linting errors from a ruff update, modifying three files with a +7/-7 line change. Successfully integrated into the codebase.
75%
#5574 style: ruff 0.12 snapcraft merged Merged after two reviewer approvals. Updates codebase for ruff 0.12 compatibility. CI passed except a non-blocking OSV-scanner failure. Changes affect 8 files with 56 additions and 23 deletions.
74%
#267 tools: configure renovate rockcraft merged Merged after approval by two reviewers. Integrates renovate configuration from starbase to automate dependency updates, adding 93 lines to a single file.
73%