← Back to issue list

tools: add ruff config

View original Github issue

Metadata

Project
rockcraft
Number
#263
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #263 added Starbase’s Ruff configuration and a Makefile test-ruff target; merged as commit 4abd39c2.

Resolution: closed resolved

Reason: PR #263 was merged into main as commit 4abd39c2. It introduced the Ruff configuration and test-ruff Makefile target; existing lint violations were deferred to separate follow-up work.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- This brings the starbase ruff config and adds a `test-ruff` to the Makefile. It doesn't add ruff to CI etc., as that'll happen when I move tox in. NOTE: Currently ruff also fails with errors - I'm making a separate PR to fix or silence these linting issues.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #263 added Starbase’s Ruff configuration and a Makefile test-ruff target; merged as commit 4abd39c2.
stealth/space-bunny-alpha — closed resolved Merged in canonical/rockcraft#263 (4abd39c2), adding Starbase’s Ruff configuration and a Makefile test-ruff target.
stealth/space-bunny-alpha — closed resolved Merged PR canonical/rockcraft#263, adding the starbase Ruff config and a Makefile test-ruff target; Ruff CI integration was deferred until the tox migration.
stealth/space-bunny-alpha — closed resolved Merged canonical/rockcraft#263, adding Starbase's Ruff configuration and a Makefile test-ruff target; CI integration and lint-error fixes were deferred to follow-up work.
qwen/qwen3.6-35b-a3b — — Merged. Added ruff configuration and a test-ruff target to the Makefile. Approved by three reviewers, introducing 89 lines across three files. Linting errors were noted for correction in a separate pull request.
qwen3.6-35b-a3b-mtp-q6 — — Merged the addition of ruff configuration and a test-ruff Makefile target. Linting errors remain unresolved and will be addressed in a separate pull request.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1232 tools: update ruff configuration to starbase v1 charmcraft merged Merged charmcraft#1232 in commit c9eb75cd, updating Ruff to Starbase v1 and applying related lint and formatting changes across 64 files.
83%
#510 build: update ruff settings craft-providers merged Merged PR #510 updated the Ruff configuration and was committed as bc34c1c.
76%
#444 fix: resolve ruff and ty lint findings craft-store merged Merged to fix ruff and ty lint findings and update ruff config, preparing for the Starbase sync in #440.
75%
#588 chore: use the latest ruff config from starbase craft-application merged Merged PR #588 as commit 44b1a940, adopting starbase's latest Ruff configuration and updating linting across 86 files for the Starflow migration.
75%
#582 style: ruff 0.16 starbase merged Merged starbase#582 ("style: ruff 0.16", +1/-0) by maintainer mr-cal, adding PLR0917 (too many positional arguments) to the per-file Ruff ignores for tests.
74%
#55 lint: stricter ruff rules starbase merged Merged PR canonical/starbase#55 as b5cda0d, tightening Ruff lint rules in one file (+23/-9) after maintainer approval.
74%
#165 style: fix linting for ruff 0.12 imagecraft merged Merged #165, incorporating canonical/starbase#408, with a four-file Ruff 0.12 compatibility style update (+7/-7).
73%
#56 lint: stricter ruff rules starbase closed Closed unmerged because the stricter Ruff configuration landed through canonical/starbase#55 in commit b5cda0d.
73%
#660 build: update ruff settings craft-parts closed Ruff configuration PR was closed unmerged after prolonged inactivity; its six-line settings update was not applied.
72%
#580 chore(linter): enable ruff base on starbase config craft-parts merged Merged in #580 via commit 111c8907, enabling Ruff based on the Starbase configuration.
72%