← Back to issue list

tools: add ruff config

View original Github issue

Metadata

Project
rockcraft
Number
#263
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged. Added ruff configuration and a test-ruff target to the Makefile. Approved by three reviewers, introducing 89 lines across three files. Linting errors were noted for correction in a separate pull request.

Suggested action:

No scores available.

Issue body

- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- This brings the starbase ruff config and adds a `test-ruff` to the Makefile. It doesn't add ruff to CI etc., as that'll happen when I move tox in. NOTE: Currently ruff also fails with errors - I'm making a separate PR to fix or silence these linting issues.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged. Added ruff configuration and a test-ruff target to the Makefile. Approved by three reviewers, introducing 89 lines across three files. Linting errors were noted for correction in a separate pull request.
qwen3.6-35b-a3b-mtp-q6 Merged the addition of ruff configuration and a test-ruff Makefile target. Linting errors remain unresolved and will be addressed in a separate pull request.
qwen3.6-35b-a3b-mtp-q6 Merged the addition of a ruff configuration and a test-ruff Makefile target. CI integration was deferred pending a tox migration, with linting errors addressed in a separate pull request.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#580 style(ruff): fix linting issues from ruff update craft-application merged Merged after approval by three reviewers. Resolves linting errors from a ruff update, modifying three files with a +7/-7 line change. Successfully integrated into the codebase.
82%
#236 build: update ruff settings craft-cli merged Merged following approval from two reviewers and passing CI checks. The change updates ruff configuration settings with a five-line modification to align linting rules.
81%
#319 style: update linting configuration for ruff 0.9 starbase merged Merged update to linting configuration for ruff 0.9. Approved by one reviewer and passed CI. The minimal two-file change was accepted after the author deferred an unrelated git_describe_command suggestion to a separate PR.
80%
#173 tools: enable ruff craft-cli merged Merged. Enabled ruff, removed pylint, and resolved associated linting, type-checking, and test coverage issues. Increased overall coverage by 0.08% and resolved issue #146.
80%
#1232 tools: update ruff configuration to starbase v1 charmcraft merged Merged after two reviewer approvals. Updated ruff configuration to starbase v1 across 64 files (+598/-525 lines). Changes resolved a circular dependency and streamlined tooling.
79%
#33 lint: fix lint issues with newer ruff craft-archives merged Merged to resolve linting failures introduced by a newer ruff version. Changes fix style checks across three files. Review approved, CI passed, and coverage remained unchanged. Additional unit tests were deferred to a separate tracking ticket.
79%
#1517 build: update ruff settings charmcraft merged Merged update to ruff configuration settings. The one-file build adjustment received approval from two reviewers and was integrated without comments or CI issues.
79%
#408 style: fix linting for ruff 0.12 starbase merged Merged a one-line update to resolve linting errors for ruff 0.12. Approved by two reviewers and passed all CI checks before integration.
79%
#68 lint: update ruff and fix linting craft-archives merged Merged into main following reviewer approval and passing CI. Updates ruff configuration and resolves linting issues across four files, maintaining 100% diff coverage with no overall coverage change.
78%
#815 fix linting issues for ruff 0.6 craft-parts merged Merged following approval from two reviewers and passing CI checks. The pull request resolves linting compatibility issues for ruff 0.6 by applying manual and automated fixes across 44 files, modifying 98 lines of code.
78%