← Back to issue list

Make library upload spread tests use a full create/destroy cycle

View original Github issue

Metadata

Project
charmcraft
Number
#1279
Type
issue
State
closed
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Resolved by merged PR #1292 (99a5a505), which made library spread tests register/unregister names instead of listing store libraries, avoiding timeout-driven CI false positives.

Resolution: closed resolved

Reason: PR #1292 was merged as commit 99a5a505 with the title "test(spread): make library tests register/unregister charms." The change implemented the requested create/destroy lifecycle and resolved #1279.

Evaluated by: mr-cal-bot

No scores available.

Issue body

### What needs to get done We have so many libraries on our default store charm that the store is timing out trying to list them for us. This isn't really necessary, since as long as we don't upload a revision we can unregister the name. https://github.com/canonical/charmcraft/blob/main/tests/spread/store/libraries/task.yaml ### Why it needs to get done CI failure false positives.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Resolved by merged PR #1292 (99a5a505), which made library spread tests register/unregister names instead of listing store libraries, avoiding timeout-driven CI false positives.
stealth/space-bunny-alpha — closed resolved Library upload spread tests now register and unregister names, avoiding broad store listings and timeout false positives; fixed by #1292 (99a5a505).
stealth/space-bunny-alpha — closed resolved Fixed in #1292 (commit 99a5a505): library upload spread tests now register/unregister charm names instead of listing all store libraries, avoiding timeout-driven CI false positives.
stealth/space-bunny-alpha — closed resolved Fixed in canonical/charmcraft#1292 (99a5a505): library spread tests now register/unregister names, avoiding store-wide listings and timeout-related CI false positives.
qwen3.6-35b-a3b-mtp-q6 — — Closed without implementation. The proposed spread test cycle adjustment was abandoned, with no associated pull request or resolution documented.
qwen/qwen3.6-35b-a3b — — Closed without a linked PR or comments. The author proposed a full create/destroy cycle for library upload spread tests to prevent CI timeouts from excessive default store libraries. No merge details provided, indicating the request was abandoned or resolved internally.
qwen/qwen3.6-35b-a3b — — Closed without implementation or linked pull request. The test update request was likely abandoned or superseded, as no comments or resolution details were recorded.
qwen3.6-35b-a3b-mtp-q6 — — Closed without a linked pull request or comments. Likely abandoned or resolved via an untracked commit, as no explicit fix for the test timeout was documented.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/charmcraft#1292 (confidence 100%)

    Merged PR #1292 directly implemented the full registration and unregistration cycle requested by #1279.

Related issues

Issue Project State Summary Similarity
#1460 fix(tests): make store spread tests less flaky charmcraft merged Merged PR #1460 as fd5bd6ba, making store spread tests less timing-sensitive and fixing flaky upload/release checks in #1429.
71%
#1292 test(spread): make library tests register/unregister charms charmcraft merged Merged #1292 in commit 99a5a505, making library spread tests register and unregister charms and fixing store-timeout failures in #1279.
70%