test(spread): make library tests register/unregister charms
Metadata
Current evaluation
Merged #1292 in commit 99a5a505, making library spread tests register and unregister charms and fixing store-timeout failures in #1279.
Resolution: closed resolved
Reason: PR #1292 was approved and merged; commit 99a5a505 introduced a full charm register/unregister lifecycle in library spread tests, resolving #1279. It built on merged PR #1290, which provided test cleanup but did not fix the timeout failure.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Fixes https://github.com/canonical/charmcraft/issues/1279
Fixes CRAFT-2068
This is built on top of #1290, which does some cleanup of the tests but doesn't fix the library test failure due to store timeouts. This fixes that. (Review the second commit here :-) )
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #1292 in commit 99a5a505, making library spread tests register and unregister charms and fixing store-timeout failures in #1279. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in #1292: library spread tests now register and unregister charms, fixing the store-timeout failures tracked in #1279. | |
| qwen/qwen3.6-35b-a3b | — | — | Fixed library test failures caused by store timeouts by updating tests to register and unregister charms. Merged following approval from two reviewers, with changes spanning two files (+22/-8 lines). | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Updates spread tests to register and unregister charms, resolving store timeout failures in library tests. Addresses #1279 and CRAFT-2068. Built atop PR #1290. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/charmcraft#1279
(confidence 100%)
Library upload spread-test failure explicitly fixed by #1292.
-
Related To:
canonical/charmcraft#1290
(confidence 98%)
Merged prerequisite PR that cleaned up store tests without resolving the library-test failure.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1324 test(spread): test-deploy charms in large spread tests | charmcraft | merged | Merged PR #1324 via commit a14d6d91, adding test deployment of charms and bundles to large Spread tests. | |
| #1217 tests: add more charms and bundles to large spread suite | charmcraft | merged | Merged #1217 as commit 0f4591a9, expanding the large spread suite with more charms and bundles to broaden breaking-change coverage. | |
| #1427 tests(spread): make dependencies restore work even if no charm is built | charmcraft | merged | Merged in canonical/charmcraft#1427 (commit 2d432044), making spread-test dependency restoration work when no charm artifact is built. | |
| #1214 tests: add more charms to large spread tests | charmcraft | closed | Closed unmerged after 1,135 days; its large-spread test expansion landed through merged PR canonical/charmcraft#1217 in commit 0f4591a9. | |
| #1198 tests: add charm library multiple versions update test | charmcraft | merged | Merged PR #1198 (commit 154bf5d6) added a 120-line regression test covering updates across multiple charm-library versions, linked to #1020/CRAFT-1916. | |
| #1290 test(spread): clean up store tests | charmcraft | merged | Merged in commit 34ab4bdd, cleaning up store spread tests by deleting 28 lines across four files; the remaining library-test failure was fixed separately in #1292. | |
| #1469 Charm upload/release spread test is flaky | charmcraft | closed | Fixed the flaky store spread test by waiting and retrying release checks; merged in canonical/charmcraft#1460 (fd5bd6ba). | |
| #1429 spread: charm upload and release store test is flaky when the store is busy | charmcraft | closed | Fixed in merged PR #1460 (commit fd5bd6ba), which reduced timing sensitivity in store upload and release Spread tests. | |
| #1266 tests(spread): requirements dependencies | charmcraft | merged | Merged PR #1266 at 97d95b39, adding spread tests for requirements-file and charm-dependency combinations; the PR explicitly fixes #1179. | |
| #2426 fix(test): fix the reactive charm spread test | charmcraft | merged | Merged in canonical/charmcraft#2426 via commit 7c33dd1b, applying a one-line fix to the reactive-charm spread test for CHARMCRAFT-641. |