test(spread): make library tests register/unregister charms
Metadata
Current evaluation
Fixed library test failures caused by store timeouts by updating tests to register and unregister charms. Merged following approval from two reviewers, with changes spanning two files (+22/-8 lines).
Suggested action: —
No scores available.
Issue body
Fixes https://github.com/canonical/charmcraft/issues/1279
Fixes CRAFT-2068
This is built on top of #1290, which does some cleanup of the tests but doesn't fix the library test failure due to store timeouts. This fixes that. (Review the second commit here :-) )
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Fixed library test failures caused by store timeouts by updating tests to register and unregister charms. Merged following approval from two reviewers, with changes spanning two files (+22/-8 lines). | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Updates spread tests to register and unregister charms, resolving store timeout failures in library tests. Addresses #1279 and CRAFT-2068. Built atop PR #1290. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to fix library test failures caused by store timeouts. Registers and unregisters charms in spread tests, resolving #1279 and CRAFT-2068. Builds on PR #1290. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1198 tests: add charm library multiple versions update test | charmcraft | merged | Merged after approval, adding a test for updating charm library multiple versions. The change introduces 120 lines to address CRAFT-1916 and issue #1020, with zero unresolved review comments. | |
| #1324 test(spread): test-deploy charms in large spread tests | charmcraft | merged | Merged to add test deployment for charms and bundles in large spread tests. Approved by two reviewers, modified six files with 85 additions and 26 deletions, and linked to a passing CI run. | |
| #1427 tests(spread): make dependencies restore work even if no charm is built | charmcraft | merged | Merged a one-line change ensuring spread test dependencies restore correctly when no charm is built. Approved by two reviewers and successfully integrated. | |
| #1217 tests: add more charms and bundles to large spread suite | charmcraft | merged | Merged test expansion adding more charms and bundles to the large spread suite to increase breaking change sensitivity. Approved by two reviewers, passed CI, and addressed timeout configuration queries. | |
| #2426 fix(test): fix the reactive charm spread test | charmcraft | merged | Merged a one-line fix for the reactive charm spread test. Approved by two reviewers and passed CI checks. Resolves CHARMCRAFT-641. | |
| #1290 test(spread): clean up store tests | charmcraft | merged | Merged cleanup of spread store tests, removing 28 lines across four files. The underlying library test failure is fixed in PR #1292. Approved by two reviewers. | |
| #1214 tests: add more charms to large spread tests | charmcraft | closed | Adding more charms to large spread tests was closed without merging. Lacking reviewer feedback or CI checks over a year, the changes were abandoned. | |
| #1235 tests: re-enable reactive charms test | charmcraft | merged | Merged a one-line update to re-enable the reactive charms test. Approved by two reviewers with no comments or CI issues. Successfully integrated into the repository. | |
| #965 (tests) Added a comment about credentials in Spread tests to use Charmhub | charmcraft | merged | Merged with approval. Added a comment to Spread tests clarifying that credentials should use Charmhub. Changes were minor (+9/-2 lines) and passed CI checks. | |
| #1287 fix(tests): fixes bundle spread test | charmcraft | merged | Merged. Resolves issue #1262 and CRAFT-2052 by fixing the bundle spread test. Replaced a failing charm path check with Python-based YAML validation. Approved by two reviewers, passed CI, and successfully executed the large spread test. |