test: remove test filesystem side-effects
Metadata
Current evaluation
Closed unmerged; broader pyfakefs fixture work was moved to #1311, which was later also closed unmerged after inactivity.
Resolution: closed superseded
Reason: After reviewers cited an existing shared fixture, maintainer lengau redirected the work with “See #1311.” PR #1310 was not merged, while successor #1311 was also eventually closed without merging.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Some tests create files in the working directory. For those, chdir to a temporary dir
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged; broader pyfakefs fixture work was moved to #1311, which was later also closed unmerged after inactivity. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged; filesystem-side-effect cleanup was replaced by charmcraft#1311, which pursued a shared pyfakefs approach but was also later closed without merging. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed without merging and superseded by charmcraft#1311, which pursued shared pyfakefs fixtures to prevent tests from writing into the working directory. | |
| qwen/qwen3.6-35b-a3b | — | — | A fix to prevent test filesystem side-effects by using a temporary directory was approved but closed and superseded by issue #1311. The author referenced the other issue after a reviewer suggested a shared fixture. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Superseded by issue #1311. The pull request was closed without merging, as the team opted to address test filesystem side-effects via a shared fixture approach detailed in the referenced issue. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
canonical/charmcraft#1311
(confidence 100%)
The maintainer explicitly directed follow-up work to #1311's broader pyfakefs approach.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1311 test: use pyfakefs where possible | charmcraft | closed | Closed unmerged after 1,087 days of inactivity, abandoning the pyfakefs test optimization; no reviews or CI checks were recorded. |