← Back to issue list

test: use pyfakefs where possible

View original Github issue

Metadata

Project
charmcraft
Number
#1311
Type
pull request
State
closed
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged after 1,087 days of inactivity, abandoning the pyfakefs test optimization; no reviews or CI checks were recorded.

Resolution: closed stale

Reason: PR #1311 never received a review or CI check and remained unmerged until it was closed after 1,087 days of inactivity. No resolving merge commit or superseding reference was recorded.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This speeds up the tests by about 10% thanks to the use of a fake (in-process) filesystem. Where we can't do that but we may have filesystem side effects, chdir to a newly-made temp path. The first commit is #1303, the second commit is this PR.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed stale Closed unmerged after 1,087 days of inactivity, abandoning the pyfakefs test optimization; no reviews or CI checks were recorded.
stealth/space-bunny-alpha — closed stale PR #1311’s pyfakefs test-speedup changes were closed unmerged after 1,087 days of inactivity, with no reviews or CI checks recorded.
stealth/space-bunny-alpha — closed stale PR #1311 was closed unmerged after 1,087 days of inactivity, abandoning the proposed pyfakefs test optimization; no reviews or CI checks were recorded.
qwen/qwen3.6-35b-a3b — — Closed without merging due to inactivity and lack of reviews. The changes proposed using pyfakefs to speed up tests by 10% via an in-process fake filesystem, but were abandoned after over two years.
qwen3.6-35b-a3b-mtp-q6 — — Merged to improve test performance by ~10% using pyfakefs for in-process filesystem mocking and temporary directories to isolate side effects.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1310 test: remove test filesystem side-effects charmcraft closed Closed unmerged; broader pyfakefs fixture work was moved to #1311, which was later also closed unmerged after inactivity.
82%
#636 build(deps): update dependency pyfakefs to v5.6.0 (hotfix/1.24) - autoclosed craft-providers closed Renovate PR #636 proposed pyfakefs 5.6.0 for hotfix/1.24 but was auto-closed unmerged after 765 days without review or CI activity.
73%
#556 test: test starbase closed Closed unmerged after 108 days; the two-line placeholder test was abandoned without review or response despite all CI checks passing.
71%