fix: make application handle a nonexistent project dir
Metadata
Current evaluation
Merged PR #1367 updated Charmcraft’s application to handle nonexistent project directories after two-reviewer approval.
Resolution: closed resolved
Reason: PR #1367 was merged, resolving the project-directory handling problem. Its description identifies #1364 as a dependency and notes that only the final commit was relevant.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Depends on #1364, only the last commit is relevant
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1367 updated Charmcraft’s application to handle nonexistent project directories after two-reviewer approval. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #1367, making the application handle nonexistent project directories; approved by two reviewers. It followed #1364, with only its final commit relevant to the fix. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix enabling the application to handle nonexistent project directories. Approved by two reviewers and dependent on PR #1364. Changes span 35 files with 989 additions and 252 deletions. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix that enables the application to gracefully handle nonexistent project directories. The resolution was applied via the final commit, which depends on PR #1364. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/charmcraft#1364
(confidence 100%)
Required prerequisite PR; #1367 states that only its final commit is relevant.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1482 fix: set the correct working directory | charmcraft | closed | Merged PR #1482 corrected the lifecycle working directory, fixing #1475 where parts directories were created inside the project; the fix shipped in Charmcraft 3.1. | |
| #253 fix(application): Only allow --project-dir for init and pack | craft-application | closed | Closed unmerged after changes were requested, with two unresolved comments and no activity for 946 days; an equivalent fix later merged in charmcraft#1565 via #1592 (06c485fc). | |
| #2600 fix: make the -p and -o arguments work correctly | charmcraft | merged | Merged PR #2600 (commit 868da353), fixing charmcraft pack to honor --project-dir and apply --output outside the container; this closes #1930. |