fix(application): Only allow --project-dir for init and pack
Metadata
Current evaluation
Closed unmerged after changes were requested, with two unresolved comments and no activity for 946 days; an equivalent fix later merged in charmcraft#1565 via #1592 (06c485fc).
Resolution: closed stale
Reason: craft-application#253 was closed unmerged with changes requested, two unresolved review comments, and roughly 946 days of inactivity. The equivalent downstream restriction was merged in charmcraft#1565 and cherry-picked by #1592 as 06c485fc.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [ ] Have you followed the guidelines for contributing?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `tox`?
-----
(CRAFT-2434)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed stale | Closed unmerged after changes were requested, with two unresolved comments and no activity for 946 days; an equivalent fix later merged in charmcraft#1565 via #1592 (06c485fc). | |
| stealth/space-bunny-alpha | — | closed stale | Craft Application #253 was closed unmerged after changes were requested, with two unresolved comments and no activity for 938 days. | |
| qwen/qwen3.6-35b-a3b | — | — | Restricting --project-dir to init and pack commands was closed without merging. Reviewers requested changes with two unresolved comments, leading to abandonment. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/charmcraft#1592
(confidence 100%)
Cherry-picked charmcraft#1565 into main as commit 06c485fc.
-
Superseded By:
canonical/charmcraft#1565
(confidence 90%)
Merged an equivalent downstream fix restricting --project-dir to init and pack.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1565 fix(cli): --project-dir should only be available for init and pack commands | charmcraft | merged | Merged #1565 restricted --project-dir to init and pack; the fix was cherry-picked into main by #1592 as 06c485fc. | |
| #2600 fix: make the -p and -o arguments work correctly | charmcraft | merged | Merged PR #2600 (commit 868da353), fixing charmcraft pack to honor --project-dir and apply --output outside the container; this closes #1930. | |
| #1583 fix(cli): restrict --project-dir to init and pack commands (#1565) | charmcraft | closed | Closed as superseded: #1592 merged the equivalent --project-dir restriction in commit 06c485fc. | |
| #1367 fix: make application handle a nonexistent project dir | charmcraft | merged | Merged PR #1367 updated Charmcraft’s application to handle nonexistent project directories after two-reviewer approval. | |
| #1592 fix(cli): restrict --project-dir to init and pack commands (#1565) | charmcraft | merged | Merged into main as 06c485fc, cherry-picking #1565 to restrict --project-dir to init and pack commands. | |
| #2498 fix: `charmcraft pack --project-dir` with metadata.yaml | charmcraft | closed | Closed unmerged; superseded by #2644, which fixed metadata lookup for --project-dir and shipped in Charmcraft 4.2.1. |