← Back to issue list

fix PYTHONPATH correctly

View original Github issue

Metadata

Project
charmcraft
Number
#147
Type
pull request
State
merged
Author
dstathis
Labels
Created
Updated
Closed

Current evaluation

Merged a fix correcting PYTHONPATH handling that incorrectly assumed env_paths contained a single value. The update properly supports virtualenvs adding multiple paths, approved by two reviewers and merged.

Suggested action:

No scores available.

Issue body

The code "env_path,) = env_paths" assumes that env_paths always has exactly one value in it. This breaks if your virtualenv adds more than one path.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a fix correcting PYTHONPATH handling that incorrectly assumed env_paths contained a single value. The update properly supports virtualenvs adding multiple paths, approved by two reviewers and merged.
qwen3.6-35b-a3b-mtp-q6 Merged a fix that corrects PYTHONPATH handling when virtualenvs supply multiple paths. The code previously failed by unpacking env_paths as a single value, which is now resolved to properly support multiple entries.
qwen3.6-35b-a3b-mtp-q6 Merged fix for PYTHONPATH handling that incorrectly unpacked env_paths assuming a single value. Resolves failures when virtualenvs inject multiple paths by properly iterating over the list.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3426 Ensure PYTHONPATH is properly set for gnome-3-34 builds snapcraft merged Merged kenvandine's fix for PYTHONPATH in gnome-3-34 builds. Approved by two reviewers, passed CI, and integrated with six lines added across two files.
72%
#392 plugins: fix pip path in python plugin craft-parts merged Merged a fix ensuring the python plugin uses the venv pip path, preventing unintended package installations when PATH changes. Approved by one reviewer, passed CI checks, and modified five files.
70%