← Back to issue list

fix: load metadata from charmcraft.yaml in profile integration tests

View original Github issue

Metadata

Project
charmcraft
Number
#1489
Type
pull request
State
closed
Author
tonyandrewmeyer
Labels
—
Created
Updated
Closed

Current evaluation

PR updating profile integration tests to read metadata from charmcraft.yaml was closed unmerged by maintainer @lengau as a duplicate of #1468, which was later superseded by merged PR #1540 (commit f3f82031) shipping the same template change.

Resolution: closed superseded

Reason: Maintainer @lengau closed this on 2024-02-22 stating it was 'the same as #1468' and closing in its favour. #1468 itself was superseded by merged PR #1540 (commit f3f82031), which updated integration-test templates from metadata.yaml to charmcraft.yaml.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Since `charmcraft init` doesn't create a `metadata.yaml` file any more, the integration tests need to load the metadata from the `charmcraft.yaml` file, since they typically run from the source folder rather than within a deployed environment.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded PR updating profile integration tests to read metadata from charmcraft.yaml was closed unmerged by maintainer @lengau as a duplicate of #1468, which was later superseded by merged PR #1540 (commit f3f82031) shipping the same template change.
stealth/space-bunny-alpha — closed superseded Closed in favor of canonical/charmcraft#1468, which addressed the same change to read charmcraft metadata in integration tests.
qwen/qwen3.6-35b-a3b — — Superseded by PR #1468. The change updates integration tests to load metadata from charmcraft.yaml instead of the deprecated metadata.yaml file.
qwen3.6-35b-a3b-mtp-q6 — — Superseded by PR #1468. The integration test fix to load metadata from charmcraft.yaml was closed as a duplicate.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/charmcraft#1468 (confidence 98%)

    Maintainer closed #1489 explicitly in favour of #1468, which made the identical metadata.yaml-to-charmcraft.yaml template change.

  • Likely Fixed By: canonical/charmcraft#1540 (confidence 92%)

    #1468 stalled on CLA signature checks and was completed by merged PR #1540 (commit f3f82031) with the same integration-test template update.

  • Caused By: canonical/charmcraft#1149 (confidence 70%)

    Earlier PR making 'charmcraft init' emit unified charmcraft.yaml only, removing metadata.yaml and breaking the integration tests this PR tried to fix.

Related issues

Issue Project State Summary Similarity
#1468 replaced metadata.yaml with charmcraft.yaml in integration test templates charmcraft closed #1468 was closed as superseded after CLA/signature blockers; PR #1540 merged the equivalent metadata.yaml-to-charmcraft.yaml integration-template update in commit f3f82031.
81%
#1540 fix: template integration tests charmcraft merged Merged PR #1540 as commit f3f82031, updating integration-test templates to use charmcraft.yaml instead of metadata.yaml and completing the stalled change from #1468.
78%
#2498 fix: `charmcraft pack --project-dir` with metadata.yaml charmcraft closed Closed unmerged; superseded by #2644, which fixed metadata lookup for --project-dir and shipped in Charmcraft 4.2.1.
70%