← Back to issue list

fix: template integration tests

View original Github issue

Metadata

Project
charmcraft
Number
#1540
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1540 as commit f3f82031, updating integration-test templates to use charmcraft.yaml instead of metadata.yaml and completing the stalled change from #1468.

Resolution: closed resolved

Reason: PR #1540 merged as commit f3f82031 with three template files changed, fixing the integration-test configuration. It superseded PR #1468 after that change stalled on an unresolved CLA signature check.

Evaluated by: mr-cal-bot

No scores available.

Issue body

see: #1468

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1540 as commit f3f82031, updating integration-test templates to use charmcraft.yaml instead of metadata.yaml and completing the stalled change from #1468.
stealth/space-bunny-alpha — closed resolved Merged #1540 as commit f3f82031, replacing metadata.yaml with charmcraft.yaml in integration-test templates after #1468 stalled on a CLA signature check.
stealth/space-bunny-alpha — closed resolved Merged #1469, replacing metadata.yaml with charmcraft.yaml in integration-test templates after #1468 stalled on an unresolved CLA signature check.
qwen/qwen3.6-35b-a3b — — Merged a maintainer fix for template integration tests. Approved by two reviewers with minimal changes (+3/-3 lines across three files). Resolves issue #1468.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix for template integration tests, resolving issue #1468. The maintainer corrected test failures and aligned the suite with current template handling.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/charmcraft#1468 (confidence 98%)

    Original replacement of metadata.yaml with charmcraft.yaml; #1540 landed the equivalent fix after #1468 stalled.

Related issues

Issue Project State Summary Similarity
#1468 replaced metadata.yaml with charmcraft.yaml in integration test templates charmcraft closed #1468 was closed as superseded after CLA/signature blockers; PR #1540 merged the equivalent metadata.yaml-to-charmcraft.yaml integration-template update in commit f3f82031.
80%
#1489 fix: load metadata from charmcraft.yaml in profile integration tests charmcraft closed PR updating profile integration tests to read metadata from charmcraft.yaml was closed unmerged by maintainer @lengau as a duplicate of #1468, which was later superseded by merged PR #1540 (commit f3f82031) shipping the same template change.
78%
#2695 feat(templates): add juju_setup to integration tests, improve comments, fix resolve() charmcraft merged Merged in charmcraft PR #2695 (commit 74d12bce), adding juju_setup to generated integration tests, clarifying comments, and removing redundant resolve().
77%
#1113 Clean up test template, make test code self-explanatory charmcraft closed Charmcraft 4.0 template updates resolved the request: PR #1551 (commit daf5a5b9) migrated generated unit tests from unittest to pytest functions/fixtures and plain assertions.
75%
#771 Fix the tests in the init template charmcraft merged Merged PR #771 fixed init-template tests broken by realistic container networking and bumped the dev `ops` dependency so generated charm tests pass.
75%
#910 Duplicate await in integration test templates charmcraft closed Fixed charmcraft init integration templates in commit 3ea45cd3 by removing the duplicate await before deployment, preventing a PosixPath TypeError.
75%
#2365 Add test configuration templates for charmcraft charmcraft closed Test init profiles delivered by merged PR #2401 (commit a7334d49), adding test-machine and test-kubernetes templates for `charmcraft init`; shipped in Charmcraft 4.0.
74%
#1287 fix(tests): fixes bundle spread test charmcraft merged Merged PR #1287 (commit f60186ce, CRAFT-2052) fixed the failing bundle spread test by validating YAML with Python and dropping a non-working charm path check, resolving #1262.
74%
#2623 feat: update charm templates to use pytest-jubilant charmcraft merged Merged PR #2623 as commit 77c4d692, updating machine and Kubernetes charm templates to use pytest-jubilant for integration tests.
73%
#132 test: update charm integration test craft-actions merged Merged in canonical/craft-actions#132 (54f7849), updating the charm pack integration test to use another simple charm after the previous Juju fixture was removed.
72%