fix(package): don't write a metadata.yaml if it already exists.
Metadata
Current evaluation
Merged #1524 in commit 9988b7db, preserving an existing generated metadata.yaml during charm packaging instead of overwriting it; provider-mode handling remained incomplete.
Resolution: closed resolved
Reason: PR #1524 merged as commit 9988b7db. It now keeps metadata already generated by a reactive charm, addressing the destructive-mode overwrite; the maintainer noted provider mode was not yet complete.
Evaluated by: mr-cal-bot
No scores available.
Issue body
No description provided.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #1524 in commit 9988b7db, preserving an existing generated metadata.yaml during charm packaging instead of overwriting it; provider-mode handling remained incomplete. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1524 (commit 9988b7db) stops the package step from overwriting an existing metadata.yaml, restoring reactive charm metadata lost by Charmcraft 3.x. Partial fix for #1488. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/charmcraft#1524 (9988b7db), preserving existing metadata.yaml during packaging; destructive mode worked, but provider-mode support remained incomplete. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #1524 (commit 9988b7db), preventing package builds from overwriting an existing metadata.yaml; a partial fix for #1488. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix preventing overwrites of existing metadata.yaml files. Approved by two reviewers, this change enables reactive charm support in destructive mode as a partial resolution for issue #1488. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix preventing redundant metadata.yaml writes for reactive charms. Addresses destructive mode behavior as part of issue #1488, with provider mode support deferred. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/charmcraft#1488
(confidence 99%)
The maintainer identified #1524 as partial work for this metadata regression, fixing destructive mode while leaving provider mode unresolved.
-
Related To:
canonical/charmcraft#1666
(confidence 85%)
Later follow-up limited retained metadata.yaml files to reactive charms, refining the reactive packaging behavior.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1666 fix: only keep metadata.yaml for reactive charms | charmcraft | merged | Merged #1666 (b2b127e6), retaining metadata.yaml only for reactive charms so non-reactive repacks no longer carry stale integration metadata; fixes #1654. | |
| #2856 Implement metadata mediation for metadata.yaml | charmcraft | closed | Fixed by merged charmcraft PR #2874, which added a craft-application package service to mediate metadata.yaml creation. |