← Back to issue list

fix(package): don't write a metadata.yaml if it already exists.

View original Github issue

Metadata

Project
charmcraft
Number
#1524
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged a fix preventing overwrites of existing metadata.yaml files. Approved by two reviewers, this change enables reactive charm support in destructive mode as a partial resolution for issue #1488.

Suggested action:

No scores available.

Issue body

No description provided.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a fix preventing overwrites of existing metadata.yaml files. Approved by two reviewers, this change enables reactive charm support in destructive mode as a partial resolution for issue #1488.
qwen3.6-35b-a3b-mtp-q6 Merged a fix preventing redundant metadata.yaml writes for reactive charms. Addresses destructive mode behavior as part of issue #1488, with provider mode support deferred.
qwen3.6-35b-a3b-mtp-q6 Merged a fix to prevent overwriting existing metadata.yaml files. This enables destructive mode operation for reactive charms as part of issue #1488, though provider mode support requires additional fixes.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1666 fix: only keep metadata.yaml for reactive charms charmcraft merged Merged to fix issue #1654 by restricting metadata.yaml retention to reactive charms only. Approved by two reviewers, passed CI, and modified six files (+101/-5).
84%
#2245 fix(reactive): don't overwrite config.yaml from a reactive charm charmcraft merged Merged following approval by three reviewers. Resolves issue #2194 and CRAFT-4206 by preventing reactive charms from overwriting config.yaml. Changes affect three files with minor code adjustments.
75%
#1151 build: do not create metafiles when using reactive charmcraft merged Merged changes preventing metafile creation for the reactive framework due to charmcraft format incompatibility. Resolves issue #1150. Approved by one reviewer, passed CI, and modified one file (+6/-3).
73%
#2502 Fix missing build metadata in reactive charm artifacts charmcraft open Adds .build.manifest preservation and charmtool_version to manifest.yaml for reactive charm builds. Fixes #872. Inactive 263 days, 0 reviewer approvals, several CI checks failing (snap-tests, Conventional Commits policy).
72%
#570 Update metadata.yaml.j2 charmcraft merged Merged an external update to metadata.yaml.j2 adding a better charm metadata reference link. Approved by one reviewer with no unresolved comments. Changed one line in one file.
71%
#1809 --project-dir fails to find metadata.yaml when running in destructive mode charmcraft open charmcraft pack --destructive-mode -p <dir> fails for reactive charms: charm proof cannot find metadata.yaml because the reactive plugin runs it in the wrong directory. Maintainer marked it low priority in Aug 2024; no fix since.
71%
#1829 fix(reactive): don't overwrite actions.yaml for reactive charms charmcraft merged Merged to fix issue #1816 by preventing the overwriting of actions.yaml for reactive charms. Approved by two reviewers, the change updates two files (+29/-5 lines) and resolves CRAFT-3247.
70%