fix: only keep metadata.yaml for reactive charms
Metadata
Current evaluation
Merged to fix issue #1654 by restricting metadata.yaml retention to reactive charms only. Approved by two reviewers, passed CI, and modified six files (+101/-5).
Suggested action: —
No scores available.
Issue body
Fixes #1654
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged to fix issue #1654 by restricting metadata.yaml retention to reactive charms only. Approved by two reviewers, passed CI, and modified six files (+101/-5). | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix restricting metadata.yaml retention to reactive charms, resolving issue #1654. Non-reactive charms no longer retain the file. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix restricting metadata.yaml retention to reactive charms only, resolving issue #1654. The change was authored by maintainer lengau and successfully integrated. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1524 fix(package): don't write a metadata.yaml if it already exists. | charmcraft | merged | Merged a fix preventing overwrites of existing metadata.yaml files. Approved by two reviewers, this change enables reactive charm support in destructive mode as a partial resolution for issue #1488. | |
| #2502 Fix missing build metadata in reactive charm artifacts | charmcraft | open | Adds .build.manifest preservation and charmtool_version to manifest.yaml for reactive charm builds. Fixes #872. Inactive 263 days, 0 reviewer approvals, several CI checks failing (snap-tests, Conventional Commits policy). | |
| #2245 fix(reactive): don't overwrite config.yaml from a reactive charm | charmcraft | merged | Merged following approval by three reviewers. Resolves issue #2194 and CRAFT-4206 by preventing reactive charms from overwriting config.yaml. Changes affect three files with minor code adjustments. | |
| #1151 build: do not create metafiles when using reactive | charmcraft | merged | Merged changes preventing metafile creation for the reactive framework due to charmcraft format incompatibility. Resolves issue #1150. Approved by one reviewer, passed CI, and modified one file (+6/-3). | |
| #1829 fix(reactive): don't overwrite actions.yaml for reactive charms | charmcraft | merged | Merged to fix issue #1816 by preventing the overwriting of actions.yaml for reactive charms. Approved by two reviewers, the change updates two files (+29/-5 lines) and resolves CRAFT-3247. | |
| #570 Update metadata.yaml.j2 | charmcraft | merged | Merged an external update to metadata.yaml.j2 adding a better charm metadata reference link. Approved by one reviewer with no unresolved comments. Changed one line in one file. | |
| #1622 fix: reorganise charmcraft.yaml preprocessing | charmcraft | merged | Merged following two approvals and passing CI. Reorganized charmcraft.yaml preprocessing to apply extensions on raw data, assign default parts to charms with bases, and enforce dictionary type for parts. Modified 5 files (+27/-14 lines). | |
| #2426 fix(test): fix the reactive charm spread test | charmcraft | merged | Merged a one-line fix for the reactive charm spread test. Approved by two reviewers and passed CI checks. Resolves CHARMCRAFT-641. | |
| #1468 replaced metadata.yaml with charmcraft.yaml in integration test templates | charmcraft | closed | Abandoned due to unresolved CLA signature issues. The maintainer confirmed the template update was valid and created a new PR to apply the changes and resolve the check. | |
| #289 fix: fix issues found in common.mk with charmcraft | starbase | merged | Merged a fix for charmcraft issues in common.mk. Approved by two reviewers with zero unresolved comments. Changed two files, adding 11 and removing 7 lines. |