fix: only keep metadata.yaml for reactive charms
Metadata
Current evaluation
Merged #1666 (b2b127e6), retaining metadata.yaml only for reactive charms so non-reactive repacks no longer carry stale integration metadata; fixes #1654.
Resolution: closed resolved
Reason: PR #1666 was approved and merged as commit b2b127e6, resolving #1654 by changing metadata.yaml retention behavior for reactive charms.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Fixes #1654
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #1666 (b2b127e6), retaining metadata.yaml only for reactive charms so non-reactive repacks no longer carry stale integration metadata; fixes #1654. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #1666 (commit b2b127e6), fixing #1654 by retaining metadata.yaml only for reactive charms and preventing stale integration data after repacking. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1666 (b2b127e6) fixed #1654 by preserving metadata.yaml only for reactive charms, preventing stale integration metadata in rebuilt charms. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #1666 (commit b2b127e6), fixing #1654 by retaining metadata.yaml only for reactive charms, preventing stale metadata after adding integrations. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #1666 (commit b2b127e6), restricting metadata.yaml retention to reactive charms and fixing #1654’s stale-metadata behavior after adding integrations. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged to fix issue #1654 by restricting metadata.yaml retention to reactive charms only. Approved by two reviewers, passed CI, and modified six files (+101/-5). | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix restricting metadata.yaml retention to reactive charms, resolving issue #1654. Non-reactive charms no longer retain the file. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
canonical/charmcraft#1654
(confidence 100%)
Stale metadata after adding an integration; the linked issue was fixed by merged PR #1666.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2502 fix: add missing build metadata in reactive charm artifacts | charmcraft | open | Adds .build.manifest preservation and charmtool_version to manifest.yaml for reactive charms. Under active review with 4 unresolved comments; most CI checks pending. | |
| #1488 Regression: 3.x places incorrect metadata.yaml in built charm (2.5.3 works) | charmcraft | closed | Fixed by #1524 (commit 9988b7db), preserving metadata generated by reactive builds; #1151 (35adadf4) provided the 2.x/edge fix. | |
| #2245 fix(reactive): don't overwrite config.yaml from a reactive charm | charmcraft | merged | Merged PR #2245 (commit aa28f0dc, CRAFT-4206) stops the package service from overwriting a config.yaml generated by a reactive charm, fixing #2194. | |
| #1524 fix(package): don't write a metadata.yaml if it already exists. | charmcraft | merged | Merged #1524 in commit 9988b7db, preserving an existing generated metadata.yaml during charm packaging instead of overwriting it; provider-mode handling remained incomplete. | |
| #1530 Changing charmcraft.yaml doesn't update the resulting charm's metadata.yaml | charmcraft | open | The original stale metadata.yaml bug was fixed by merged PR #2874; a later Charmcraft 5.5.0 stale-repack variant remains tracked in craft-application#821. | |
| #1829 fix(reactive): don't overwrite actions.yaml for reactive charms | charmcraft | merged | Merged #1829 as commit 4a3cbacb, fixing #1816 by preserving reactive charms' existing actions.yaml instead of overwriting it. | |
| #1468 replaced metadata.yaml with charmcraft.yaml in integration test templates | charmcraft | closed | #1468 was closed as superseded after CLA/signature blockers; PR #1540 merged the equivalent metadata.yaml-to-charmcraft.yaml integration-template update in commit f3f82031. | |
| #2498 fix: `charmcraft pack --project-dir` with metadata.yaml | charmcraft | closed | Closed unmerged; superseded by #2644, which fixed metadata lookup for --project-dir and shipped in Charmcraft 4.2.1. | |
| #570 Update metadata.yaml.j2 | charmcraft | merged | Merged #570 in commit f690f605, updating metadata.yaml.j2 with a more complete charm metadata reference link. | |
| #1151 build: do not create metafiles when using reactive | charmcraft | merged | Merged #1151 as commit 35adadf4, stopping Charmcraft from generating metafiles for reactive builds and preserving Reactive's own format; fixes #1150. |