← Back to issue list

test: add regression test for manila charm

View original Github issue

Metadata

Project
charmcraft
Number
#1541
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged as d531c104, adding a one-line regression test that packages the Manila charm and guards the metadata regression tracked in canonical/charmcraft#1488.

Resolution: closed resolved

Reason: Pull request #1541 was approved and merged as commit d531c104. Its regression test covers the Manila packaging problem from #1488, whose underlying metadata fix was provided by #1524 (9988b7db).

Evaluated by: mr-cal-bot

No scores available.

Issue body

See: https://github.com/canonical/charmcraft/issues/1488

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as d531c104, adding a one-line regression test that packages the Manila charm and guards the metadata regression tracked in canonical/charmcraft#1488.
stealth/space-bunny-alpha — closed resolved Merged #1541 as d531c104, adding the Manila reactive charm to spread tests as a regression case for #1488.
stealth/space-bunny-alpha — closed resolved Merged PR #1541 as commit d531c104, adding Manila to the external reactive charm packaging regression test.
stealth/space-bunny-alpha — closed resolved Merged PR #1541 as commit d531c104, adding a one-line regression test for the manila charm covering the packaging regression reported in #1488.
stealth/space-bunny-alpha — closed resolved Merged PR canonical/charmcraft#1541 added a one-line regression test for the Manila charm, covering the regression tracked in issue #1488.
qwen/qwen3.6-35b-a3b — — Merged a regression test for the manila charm to address charmcraft issue #1488. Approved by three reviewers, the change adds a single line to one file and resolves the reported regression.
qwen3.6-35b-a3b-mtp-q6 — — Merged a regression test for the manila charm to address charmcraft issue #1488. The pull request was integrated into the main branch by maintainer lengau, adding automated coverage for the reported behavior.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/charmcraft#1488 (confidence 100%)

    The PR explicitly references this metadata regression issue and adds Manila-specific coverage.

  • Likely Fixed By: canonical/charmcraft#1524 (confidence 95%)

    Commit 9988b7db fixed the underlying generated-metadata preservation problem.

Related issues

Issue Project State Summary Similarity
#1198 tests: add charm library multiple versions update test charmcraft merged Merged PR #1198 (commit 154bf5d6) added a 120-line regression test covering updates across multiple charm-library versions, linked to #1020/CRAFT-1916.
74%
#1235 tests: re-enable reactive charms test charmcraft merged Merged PR canonical/charmcraft#1235 as commit bff2a6a3, re-enabling the reactive charms test with a one-line change after two approvals.
72%