← Back to issue list

Add the `flask-framework` extension

View original Github issue

Metadata

Project
charmcraft
Number
#1582
Type
pull request
State
merged
Author
weiiwang01
Labels
—
Created
Updated
Closed

Current evaluation

Merged the flask-framework extension and init profile into Charmcraft via PR #1582 (commit c060832a), including a fix to skip tox testing when no tox.ini is generated.

Resolution: closed resolved

Reason: PR #1582 was approved and merged into main as commit c060832a. It adds the Flask 12-factor extension and init profile, with a test adjustment preventing tox from running when tox.ini is absent.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Bring the `flask-framework` extension from the `feature/12f` branch into the main branch. The `flask-extension` is a part of the 12-factor toolchain that assists users in creating a charm to manage their Flask application within the Juju ecosystem. As we are still awaiting some changes in other libraries to be finalized, please review the current content. I will update the pull request once the changes in the other libraries have been merged.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged the flask-framework extension and init profile into Charmcraft via PR #1582 (commit c060832a), including a fix to skip tox testing when no tox.ini is generated.
stealth/space-bunny-alpha — closed resolved Merged PR #1582 added the flask-framework 12-factor extension and init profile, with a fix to skip tox tests when no tox.ini is generated.
stealth/space-bunny-alpha — closed resolved Merged PR #1582 in commit c060832a, adding the flask-framework 12-factor extension and init profile. The macOS timeout was fixed by skipping tox tests when the profile generates no tox.ini.
qwen/qwen3.6-35b-a3b — — Merged the flask-framework extension to main. Resolved a macOS test timeout by updating the test suite to skip execution when the tox.ini configuration file is not generated, ensuring successful CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged the flask-framework extension to main. Fixed a macOS test timeout by skipping test_tox_success when the init profile omits tox.ini generation, preventing an infinite loop.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1257 Add the flask extension charmcraft merged Merged as an experimental Flask extension change; the completed flask-framework implementation landed in follow-up PR #1582 via commit c060832a.
78%
#1428 Add init template for flask-framework charmcraft merged PR #1428 was merged, adding the flask-framework profile and basic init template for 12-factor Flask charms.
76%
#492 Add `django-framework` extension and `django-framework` init profile rockcraft merged Django support shipped via follow-up PR #534, merged as commit e86bf33b, adding the experimental extension and init profile plus Flask-related refactors.
74%
#1578 feat(extension): support django-framework charmcraft merged Merged in canonical/charmcraft#1578, adding Django framework extension support and refactoring the Flask extension.
72%
#1718 Flask extension. Allow charm-libs to be extended by the user charmcraft merged PR #1718 merged as commit 4ff7cee3, fixing the Flask extension so a user-defined charm-libs list in charmcraft.yaml is merged with the extension's _CHARM_LIBS instead of raising AttributeError.
71%