Flask extension. Allow charm-libs to be extended by the user
Metadata
Current evaluation
Merged. Resolves Flask extension AttributeError when charm-libs is pre-defined in charmcraft.yaml. Combines and deduplicates charm-libs from both extension and user configs. Approved and passed CI.
Suggested action: —
No scores available.
Issue body
As pointed by @mr-cal in https://github.com/canonical/charmcraft/pull/1691#pullrequestreview-2156902965, the Flask extension fails when a `charm-libs` is already defined in a `charmcraft.yaml`, with a not very clear message because of an `AttributeError` exception.
This PR allows having a `charm-libs` in the original `charmcraft.yaml`, and will combine both `charm-libs` lists (if there are duplicated elements they will be only downloaded once).
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged. Resolves Flask extension AttributeError when charm-libs is pre-defined in charmcraft.yaml. Combines and deduplicates charm-libs from both extension and user configs. Approved and passed CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Fixes a Flask extension AttributeError when charm-libs is pre-defined in charmcraft.yaml. The change combines and deduplicates charm-libs from both the extension and user configuration. Approved and merged by maintainers. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Resolves an AttributeError in the Flask extension when charm-libs is pre-defined in charmcraft.yaml. The update merges user and extension charm-libs lists, deduplicating entries. Approved by @lengau. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1257 Add the flask extension | charmcraft | merged | Merged an experimental Flask extension for charmcraft's Juju 12-factor charm ecosystem. Approved by two reviewers and integrated after incorporating sprint demo updates and addressing testing requirements. | |
| #2556 fix: charmcraft templates for flask and django extensions | charmcraft | merged | Merged external contribution adding the missing platforms key to charmcraft.yaml templates for Flask and Django 12-factor extensions. Approved by two reviewers, passed CI checks, and updated documentation. | |
| #1620 fix: add default charm part in flask-framework | charmcraft | merged | Merged PR adds the default charm part to the flask-framework extension and prevents conflicts with custom configurations. Template dependencies were updated to fix sdist builds, resolving issue #1616. |