← Back to issue list

chore(deps): update dependency protobuf to v5

View original Github issue

Metadata

Project
charmcraft
Number
#1639
Type
pull request
State
merged
Author
renovate[bot]
Labels
—
Created
Updated
Closed

Current evaluation

Renovate bumped protobuf from ==3.20.3 to ==5.26.1 in requirements files; merged via commit c3805214. Safe since protobuf is only an indirect dep via macaroonbakery, which gained protobuf 4/5 support upstream.

Resolution: closed resolved

Reason: The PR was approved by 2 reviewers (lengau confirmed no API changes, noting protobuf is an indirect dependency via macaroonbakery) and merged as commit c3805214 "chore(deps): update dependency protobuf to v5 (#1639)", pinning protobuf==5.26.1. Later commit f2fe9c79 (#1946) further bumped protobuf to 5.28.2, confirming the v5 pin landed and stuck.

Evaluated by: mr-cal-bot

No scores available.

Issue body

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [protobuf](https://developers.google.com/protocol-buffers/) | `==3.20.3` -> `==5.26.1` | [![age](https://developer.mend.io/api/mc/badges/age/pypi/protobuf/5.26.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/protobuf/5.26.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/protobuf/3.20.3/5.26.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/protobuf/3.20.3/5.26.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - "every weekend" in timezone Etc/UTC, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/canonical/charmcraft). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Renovate bumped protobuf from ==3.20.3 to ==5.26.1 in requirements files; merged via commit c3805214. Safe since protobuf is only an indirect dep via macaroonbakery, which gained protobuf 4/5 support upstream.
stealth/space-bunny-alpha — closed resolved Merged PR #1639 (c3805214), upgrading the indirect protobuf dependency from 3.20.3 to 5.26.1.
qwen/qwen3.6-35b-a3b — — Merged a Renovate update upgrading the indirect protobuf dependency from v3.20.3 to v5.26.1. Approved by two reviewers with passing CI. Confirmed as an indirect dependency via macaroonbakery requiring no API changes.
qwen3.6-35b-a3b-mtp-q6 — — Merged automated dependency update upgrading protobuf from v3.20.3 to v5.26.1. Maintainers confirmed the change is safe as protobuf is an indirect dependency via macaroonbakery, which supports both versions.

Update history

No update history recorded yet.

Related work

  • Related To: py-macaroon-bakery#95 (confidence 90%)

    Upstream py-macaroon-bakery PR adding protobuf 4/5 compatibility, cited by lengau as the reason the major bump is safe for charmcraft

  • Related To: canonical/charmcraft#1946 (confidence 70%)

    Follow-up Renovate PR bumping protobuf to v5.28.2, showing the v5 pin from #1639 remained in effect

Related issues

Issue Project State Summary Similarity
#980 chore(deps): update dependency protobuf to v4 charmcraft closed Renovate PR to bump protobuf ==3.20.3 -> ==4.21.12 was closed unmerged on 2023-01-20; lengau denied it because macaroonbakery required protobuf 3. Renovate ignored4.x afterwards; the bump only landed later via #1639 (v5, commit c3805214).
88%
#131 chore(deps): freeze protobuf craft-store merged Merged #131 as commit 317166c, freezing protobuf to avoid incompatibilities tracked by py-macaroon-bakery#94.
75%
#132 Remove protobuf requirement craft-store closed Removed the temporary protobuf constraint after macaroonbakery 1.3.4 fixed upstream #94; PR #156 merged as b67cf49 and shipped in craft-store 2.6.1.
71%
#1946 build(deps): update dependency protobuf to v5.28.2 (main) charmcraft merged Renovate dependency bump merged: protobuf 5.27.3 -> 5.28.2 in pyproject.toml and uv.lock, merged to main as commit f2fe9c79 (approved by 2 reviewers).
70%