Remove protobuf requirement
Metadata
Current evaluation
Removed the temporary protobuf constraint after macaroonbakery 1.3.4 fixed upstream #94; PR #156 merged as b67cf49 and shipped in craft-store 2.6.1.
Resolution: closed resolved
Reason: PR #156 was merged as commit b67cf49, removing the protobuf dependency and resolving #132 after macaroonbakery 1.3.4 fixed the upstream incompatibility. The 2.6.1 changelog confirms the protobuf dependency was removed.
Evaluated by: mr-cal-bot
No scores available.
Issue body
### What needs to get done
- [ ] Revert this PR: https://github.com/canonical/craft-store/pull/131
- [ ] Remove protobuf from renovate.json's `ignoreDeps`
When there's a release of macaroonbakery that fixes this: https://github.com/go-macaroon-bakery/py-macaroon-bakery/issues/94
### Why it needs to get done
We don't directly depend on protobuf, we just needed to limit the version for CI until the resolution of https://github.com/go-macaroon-bakery/py-macaroon-bakery/issues/94
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Removed the temporary protobuf constraint after macaroonbakery 1.3.4 fixed upstream #94; PR #156 merged as b67cf49 and shipped in craft-store 2.6.1. | |
| stealth/space-bunny-alpha | — | closed resolved | Resolved by canonical/craft-store#156 (commit b67cf49), which removed the protobuf dependency and restriction after macaroonbakery 1.3.4 fixed upstream compatibility. | |
| qwen/qwen3.6-35b-a3b | — | — | Protobuf version restriction was removed after upstream py-macaroon-bakery released v1.3.4, resolving the CI compatibility block. The maintainer confirmed the fix and closed the issue. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed as resolved. The issue tracked removing a temporary protobuf CI pin until an upstream macaroonbakery fix was released. The maintainer confirmed version 1.3.4 resolves the dependency, unblocking the requirement removal. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed after upstream py-macaroon-bakery 1.3.4 resolved the compatibility issue. The protobuf version restriction was reverted and removed from renovate configuration, completing the requested changes. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
canonical/craft-store#156
(confidence 100%)
Merged PR removing the protobuf dependency; commit b67cf49.
-
Related To:
py-macaroon-bakery#94
(confidence 98%)
Upstream protobuf compatibility problem was fixed in macaroonbakery 1.3.4.
-
Caused By:
canonical/craft-store#131
(confidence 95%)
The earlier protobuf restriction was the change #132 sought to revert.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #156 build(deps): remove protobuf dep | craft-store | merged | Merged PR #156 as commit b67cf49, removing the protobuf dependency and fixing #132. The change was released in craft-store 2.6.1. | |
| #980 chore(deps): update dependency protobuf to v4 | charmcraft | closed | Renovate PR to bump protobuf ==3.20.3 -> ==4.21.12 was closed unmerged on 2023-01-20; lengau denied it because macaroonbakery required protobuf 3. Renovate ignored4.x afterwards; the bump only landed later via #1639 (v5, commit c3805214). | |
| #1639 chore(deps): update dependency protobuf to v5 | charmcraft | merged | Renovate bumped protobuf from ==3.20.3 to ==5.26.1 in requirements files; merged via commit c3805214. Safe since protobuf is only an indirect dep via macaroonbakery, which gained protobuf 4/5 support upstream. |