← Back to issue list

fix: make tox tests succeed

View original Github issue

Metadata

Project
charmcraft
Number
#1674
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged in commit b24ccd5b: fixed the tox environment variable and added a workaround for canonical/operator#1212, allowing tox tests to succeed.

Resolution: closed resolved

Reason: PR #1674 was merged and resolving commit b24ccd5b addressed the tox environment-variable failure while adding a workaround for canonical/operator#1212.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Includes both a fix for the environment variable and a workaround for https://github.com/canonical/operator/issues/1212

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in commit b24ccd5b: fixed the tox environment variable and added a workaround for canonical/operator#1212, allowing tox tests to succeed.
stealth/space-bunny-alpha — closed resolved Merged charmcraft#1674 in commit b24ccd5b, fixing a tox environment variable and adding a workaround for canonical/operator#1212.
qwen/qwen3.6-35b-a3b — — Merged to fix failing tox tests by correcting an environment variable and working around canonical/operator#1212. Approved by two reviewers with a 7-line addition and 2 deletions across three files.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix that resolves tox test failures by correcting an environment variable and applying a workaround for canonical/operator#1212. Changes were integrated into the main branch.

Update history

No update history recorded yet.

Related work

  • Related To: operator#1212 (confidence 99%)

    The PR explicitly added a workaround for this operator-framework issue.

Related issues

Issue Project State Summary Similarity
#477 tox: fix broken tox environments craft-parts merged Merged #477 fixed the broken tox environments, updating four files (+8/-3) in commit 64677494.
76%
#1423 build: use tox for tests charmcraft merged Merged #1423 in commit 8b291de3, moving test execution to tox so tox handles Python versions while CI matrices cover operating systems.
74%
#4273 docs: fix tox doc builds snapcraft merged Merged PR #4273 fixed tox documentation builds; the change landed on main as commit d25b49d63.
73%
#4036 tests: ensure coverage is set per tox env snapcraft merged Merged #4036 in commit ef29278e2, setting test coverage independently for each tox environment.
73%
#4058 tox: fix linters and makefile snapcraft merged PR #4058 by lengau merged as commit be5d4307 ("tox: fix linters and makefile"), correcting linter config in tox.ini and the Makefile after the starbase tox migration (#4046). Codecov reported no coverage change.
73%
#332 tox: improve UX for testing craft-providers merged Merged PR #332 as commit 38739ea, updating tox configuration to improve the local testing experience.
73%
#1508 `init` tox tests failing on macos 11 charmcraft closed The macOS 11 init/tox failure was fixed by merged PR #1674 (commit b24ccd5b), which corrected tox environment handling and added a workaround for operator#1212.
72%
#616 build: use tox for unit tests in CI craft-parts merged Merged PR #616 switched unit-test CI to tox; it was approved by two reviewers and landed as commit bd6c687f.
72%
#66 tools: fix ruff linting command in tox starbase merged Merged #66 as commit 189835b, correcting the one-line Ruff lint invocation in tox.
72%
#67 lint: fix ruff linting in tox craft-archives merged PR #67 was merged as commit 0148023, fixing Ruff linting configuration in tox.
72%