← Back to issue list

tox: fix linters and makefile

View original Github issue

Metadata

Project
snapcraft
Number
#4058
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged into main after approval and passing CI. Fixes tox linter configurations and updates the Makefile, with no impact on test coverage.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `pytest tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged into main after approval and passing CI. Fixes tox linter configurations and updates the Makefile, with no impact on test coverage.
qwen3.6-35b-a3b-mtp-q6 Merged into main. Updated tox configuration to fix linter warnings and correct the makefile. Codecov confirmed no coverage impact. Changes were integrated without modification.
qwen3.6-35b-a3b-mtp-q6 Merged into main. Resolves linter failures and updates Makefile targets for tox. Codecov reports zero coverage change upon merge.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#106 tox: improve UX starbase merged Merged into main following reviewer approval and passing CI. Resolves #105 by improving tox UX across three files. Changes maintain 100% test coverage with no impact on overall metrics.
81%
#67 lint: fix ruff linting in tox craft-archives merged Merged after reviewer approval and passing CI. Resolves ruff linting issues in the tox environment by updating three files. Code coverage remains unchanged at 88.07%.
80%
#4273 docs: fix tox doc builds snapcraft merged Merged to main after reviewer approval and passing CI. The change fixes tox documentation builds by modifying a single file (+2/-12 lines), with no impact on code coverage.
80%
#477 tox: fix broken tox environments craft-parts merged Merged a maintainer pull request fixing broken tox environments. The update modifies four files with eight additions and three deletions and received one reviewer approval before integration.
78%
#4820 fix(tox): use requirements-devel for linters snapcraft merged Merged a pull request updating the tox configuration to use requirements-devel for linters. Approved by two reviewers and passing CI, the change modifies one file to resolve linting dependencies.
78%
#66 tools: fix ruff linting command in tox starbase merged Merged a one-line fix that corrected the ruff linting command in tox. The change received reviewer approval and was successfully integrated into the codebase.
77%
#4416 style: fix ruff format tox environment snapcraft merged Merged into main after passing CI and two approvals. The PR fixes the ruff format tox environment configuration, changing one file (+2/-3 lines).
76%
#1674 fix: make tox tests succeed charmcraft merged Merged to fix failing tox tests by correcting an environment variable and working around canonical/operator#1212. Approved by two reviewers with a 7-line addition and 2 deletions across three files.
76%
#1755 fix(ci): fix tox ensure_version_matches charmcraft merged Merged after approval by two reviewers. Resolved a CI failure in the tox ensure_version_matches check with a single-line adjustment. The fix was successfully integrated into the codebase.
75%
#4005 Testing: Lint and test using Tox snapcraft merged Merged after two approvals and passing CI. Configured Tox for linting and unit testing with a new GitHub Actions workflow. Legacy testing remains temporarily for comparison. Code coverage unchanged.
75%