← Back to issue list

tox: fix linters and makefile

View original Github issue

Metadata

Project
snapcraft
Number
#4058
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

PR #4058 by lengau merged as commit be5d4307 ("tox: fix linters and makefile"), correcting linter config in tox.ini and the Makefile after the starbase tox migration (#4046). Codecov reported no coverage change.

Resolution: closed resolved

Reason: The PR itself was approved and merged into main as commit be5d43079, a 2-file (+16/-13) fix to the tox linter configuration and Makefile. Follow-up work landed separately in #4073 (reintroduce pylint in tox) and #4059 (codespell update).

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `pytest tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #4058 by lengau merged as commit be5d4307 ("tox: fix linters and makefile"), correcting linter config in tox.ini and the Makefile after the starbase tox migration (#4046). Codecov reported no coverage change.
stealth/space-bunny-alpha — closed resolved Merged PR #4058 as commit be5d43079, fixing tox linter configuration and updating the Makefile; Codecov reported no coverage change.
qwen/qwen3.6-35b-a3b — — Merged into main after approval and passing CI. Fixes tox linter configurations and updates the Makefile, with no impact on test coverage.
qwen3.6-35b-a3b-mtp-q6 — — Merged into main. Updated tox configuration to fix linter warnings and correct the makefile. Codecov confirmed no coverage impact. Changes were integrated without modification.

Update history

No update history recorded yet.

Related work

  • Related To: snapcore/snapcraft#4046 (confidence 70%)

    PR #4046 moved snapcraft to the starbase tox configuration; #4058 immediately fixed resulting linter/Makefile breakage.

  • Related To: snapcore/snapcraft#4073 (confidence 65%)

    Commit edd11ada8 (#4073) reintroduced pylint in tox shortly after, extending the same lint setup.

  • Related To: snapcore/snapcraft#4059 (confidence 60%)

    Commit 255255f7b (#4059) updated and froze codespell in the same lint stack as #4058.

Related issues

Issue Project State Summary Similarity
#477 tox: fix broken tox environments craft-parts merged Merged #477 fixed the broken tox environments, updating four files (+8/-3) in commit 64677494.
79%
#4820 fix(tox): use requirements-devel for linters snapcraft merged PR #4820 merged as commit e6a0f5c3a, adding 4 lines to tox.ini so the lint environment installs linter dependencies from requirements-devel instead of an ad-hoc list. tox.ini was later deleted (18a7596c9).
78%
#1062 tools: import tox from starbase charmcraft merged Merged as commit 4ed52927, adding Starbase's tox configuration across eight files; CI adoption was deferred because several linters failed.
77%
#332 tox: improve UX for testing craft-providers merged Merged PR #332 as commit 38739ea, updating tox configuration to improve the local testing experience.
77%
#67 lint: fix ruff linting in tox craft-archives merged PR #67 was merged as commit 0148023, fixing Ruff linting configuration in tox.
76%
#4005 Testing: Lint and test using Tox snapcraft merged Merged PR #4005 (4526909), adding Tox-based linting and unit-test GitHub Actions while retaining legacy checks for comparison.
75%
#11 tools: use the starbase tox config craft-grammar merged PR #11 by lengau merged (commit 697e4dd) adding Starbase's tox configuration: tox.ini plus four supporting config files, 183 added lines. tox.ini later dropped in #310 after rebasing on Starbase.
75%
#433 tox: basic tox from starbase craft-parts merged Merged the Starbase-derived tox configuration in PR #433 (commit 7dbf0405), updating 24 files.
75%
#1674 fix: make tox tests succeed charmcraft merged Merged in commit b24ccd5b: fixed the tox environment variable and added a workaround for canonical/operator#1212, allowing tox tests to succeed.
73%
#53 tox: move deps from tox.ini into pyproject.toml starbase merged PR #53 by lengau merged, relocating tox dependency declarations from tox.ini into pyproject.toml (commit 4adb069; +19/-29 across tox.ini and pyproject.toml).
73%