← Back to issue list

ci: enable merge groups for CI

View original Github issue

Metadata

Project
charmcraft
Number
#1676
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged as commit 1762b90b, adding merge_group triggers to Charmcraft's CI workflows (3 files, +5/-1) so PR checks also run in merge groups — an initial step toward a merge queue.

Resolution: closed resolved

Reason: The PR itself was merged to main as commit 1762b90b with 2 approvals and no unresolved comments. Follow-up work landed in #1679/#1680 (claude-check removed from merge groups) and #1735/#1738 (merge-queue publishing fixes).

Evaluated by: mr-cal-bot

No scores available.

Issue body

This doesn't set up a full merge queue, but it starts the process, as it allows all the CI items that run on PRs to also run on merge groups.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as commit 1762b90b, adding merge_group triggers to Charmcraft's CI workflows (3 files, +5/-1) so PR checks also run in merge groups — an initial step toward a merge queue.
stealth/space-bunny-alpha — closed resolved Merged #1676 (commit 1762b90b), extending existing PR CI checks to GitHub merge groups as an initial step toward merge queues.
stealth/space-bunny-alpha — closed resolved Merged #1676 (commit 1762b90b), enabling the existing PR CI checks to run on GitHub merge groups as an initial step toward merge queues.
qwen/qwen3.6-35b-a3b — — Merged to enable CI checks on merge groups. Approved by two reviewers and passed all checks. This initial step allows PR CI jobs to run on merge groups, establishing groundwork for a full merge queue. Minimal changes across three files.
qwen3.6-35b-a3b-mtp-q6 — — Merged to enable CI execution on merge groups, establishing the foundation for a full merge queue. The change routes existing PR checks to merge groups, serving as an initial implementation trial.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/charmcraft#1679 (confidence 90%)

    Follow-up PR removing cla-check from the merge groups added here; commit a21958a3

  • Related To: canonical/charmcraft#1680 (confidence 80%)

    Second attempt at the same cla-check removal from merge groups; commit e2ad204f

  • Related To: canonical/charmcraft#1735 (confidence 65%)

    Later fix for publishing to the correct branch from the merge queue, a direct consequence of enabling merge groups

  • Related To: canonical/charmcraft#1738 (confidence 60%)

    Follow-up fix to merge-event handling in CI tests now that merge groups/queue events fire

  • Related To: canonical/starbase#211 (confidence 55%)

    Tracking issue for the broader merge queue / Starbase work referenced in the PR comment

Related issues

Issue Project State Summary Similarity
#1679 ci: remove cla-check from merge groups charmcraft merged Merged PR #1679 removed cla-check from Charmcraft merge groups with a one-line GitHub Actions configuration change.
76%
#211 Merge queues starbase open Maintainer tracking issue to try out GitHub merge queues (prototype in charmcraft#1676). Idle876 days: no merge_group trigger added, no documented configuration, and CI has since moved to shared starflow workflows.
73%
#1680 ci: remove cla-check from merge groups charmcraft merged Merged PR #1680 as commit e2ad204f, updating CI to exclude cla-check from merge-group runs.
73%
#49 ci: test the charmcraft actions in more places craft-actions merged Merged PR #49 in commit a8e5310, expanding Charmcraft action CI coverage across more Ubuntu architectures, channels, and pinned-revision runs.
70%