← Back to issue list

chore(deps): update dependency requests to v2.32.2 [security]

View original Github issue

Metadata

Project
charmcraft
Number
#1709
Type
pull request
State
closed
Author
renovate[bot]
Labels
β€”
Created
Updated
Closed

Current evaluation

Requests 2.32.2 security update #1709 was closed unmerged due to dependency conflicts; its pin change was not applied. A later merged update reached Requests 2.33.0 in #2612 (3a73fbc1).

Resolution: closed stale

Reason: The PR was abandoned after maintainer @lengau commented, "Not possible due to dependency conflicts," and it was closed without a merge commit. Requests was later advanced to 2.33.0 by merged PR #2612.

Evaluated by: mr-cal-bot

No scores available.

Issue body

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [requests](https://requests.readthedocs.io) ([source](https://togithub.com/psf/requests), [changelog](https://togithub.com/psf/requests/blob/master/HISTORY.md)) | `==2.31.0` -> `==2.32.2` | [![age](https://developer.mend.io/api/mc/badges/age/pypi/requests/2.32.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/requests/2.32.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/requests/2.31.0/2.32.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/requests/2.31.0/2.32.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | ### GitHub Vulnerability Alerts #### [CVE-2024-35195](https://togithub.com/psf/requests/security/advisories/GHSA-9wx4-h78v-vm56) When making requests through a Requests `Session`, if the first request is made with `verify=False` to disable cert verification, all subsequent requests to the same origin will continue to ignore cert verification regardless of changes to the value of `verify`. This behavior will continue for the lifecycle of the connection in the connection pool. ### Remediation Any of these options can be used to remediate the current issue, we highly recommend upgrading as the preferred mitigation. * Upgrade to `requests>=2.32.0`. * For `requests<2.32.0`, avoid setting `verify=False` for the first request to a host while using a Requests Session. * For `requests<2.32.0`, call `close()` on `Session` objects to clear existing connections if `verify=False` is used. ### Related Links * [https://github.com/psf/requests/pull/6655](https://togithub.com/psf/requests/pull/6655) --- ### Release Notes <details> <summary>psf/requests (requests)</summary> ### [`v2.32.2`](https://togithub.com/psf/requests/blob/HEAD/HISTORY.md#2322-2024-05-21) [Compare Source](https://togithub.com/psf/requests/compare/v2.32.1...v2.32.2) **Deprecations** - To provide a more stable migration for custom HTTPAdapters impacted by the CVE changes in 2.32.0, we've renamed `_get_connection` to a new public API, `get_connection_with_tls_context`. Existing custom HTTPAdapters will need to migrate their code to use this new API. `get_connection` is considered deprecated in all versions of Requests>=2.32.0. A minimal (2-line) example has been provided in the linked PR to ease migration, but we strongly urge users to evaluate if their custom adapter is subject to the same issue described in CVE-2024-35195. ([#&#8203;6710](https://togithub.com/psf/requests/issues/6710)) ### [`v2.32.1`](https://togithub.com/psf/requests/blob/HEAD/HISTORY.md#2321-2024-05-20) [Compare Source](https://togithub.com/psf/requests/compare/v2.32.0...v2.32.1) **Bugfixes** - Add missing test certs to the sdist distributed on PyPI. ### [`v2.32.0`](https://togithub.com/psf/requests/blob/HEAD/HISTORY.md#2320-2024-05-20) [Compare Source](https://togithub.com/psf/requests/compare/v2.31.0...v2.32.0) **Security** - Fixed an issue where setting `verify=False` on the first request from a Session will cause subsequent requests to the *same origin* to also ignore cert verification, regardless of the value of `verify`. (https://github.com/psf/requests/security/advisories/GHSA-9wx4-h78v-vm56) **Improvements** - `verify=True` now reuses a global SSLContext which should improve request time variance between first and subsequent requests. It should also minimize certificate load time on Windows systems when using a Python version built with OpenSSL 3.x. ([#&#8203;6667](https://togithub.com/psf/requests/issues/6667)) - Requests now supports optional use of character detection (`chardet` or `charset_normalizer`) when repackaged or vendored. This enables `pip` and other projects to minimize their vendoring surface area. The `Response.text()` and `apparent_encoding` APIs will default to `utf-8` if neither library is present. ([#&#8203;6702](https://togithub.com/psf/requests/issues/6702)) **Bugfixes** - Fixed bug in length detection where emoji length was incorrectly calculated in the request content-length. ([#&#8203;6589](https://togithub.com/psf/requests/issues/6589)) - Fixed deserialization bug in JSONDecodeError. ([#&#8203;6629](https://togithub.com/psf/requests/issues/6629)) - Fixed bug where an extra leading `/` (path separator) could lead urllib3 to unnecessarily reparse the request URI. ([#&#8203;6644](https://togithub.com/psf/requests/issues/6644)) **Deprecations** - Requests has officially added support for CPython 3.12 ([#&#8203;6503](https://togithub.com/psf/requests/issues/6503)) - Requests has officially added support for PyPy 3.9 and 3.10 ([#&#8203;6641](https://togithub.com/psf/requests/issues/6641)) - Requests has officially dropped support for CPython 3.7 ([#&#8203;6642](https://togithub.com/psf/requests/issues/6642)) - Requests has officially dropped support for PyPy 3.7 and 3.8 ([#&#8203;6641](https://togithub.com/psf/requests/issues/6641)) **Documentation** - Various typo fixes and doc improvements. **Packaging** - Requests has started adopting some modern packaging practices. The source files for the projects (formerly `requests`) is now located in `src/requests` in the Requests sdist. ([#&#8203;6506](https://togithub.com/psf/requests/issues/6506)) - Starting in Requests 2.33.0, Requests will migrate to a PEP 517 build system using `hatchling`. This should not impact the average user, but extremely old versions of packaging utilities may have issues with the new packaging format. </details> --- ### Configuration πŸ“… **Schedule**: Branch creation - "" in timezone Etc/UTC, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. β™» **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. πŸ”• **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/canonical/charmcraft). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTAuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQxMC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=-->

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha β€” closed stale Requests 2.32.2 security update #1709 was closed unmerged due to dependency conflicts; its pin change was not applied. A later merged update reached Requests 2.33.0 in #2612 (3a73fbc1).
stealth/space-bunny-alpha β€” closed stale Renovate's requests 2.32.2 security bump was abandoned unmerged after a maintainer reported dependency conflicts; no repository change was applied.
stealth/space-bunny-alpha β€” closed stale Requests 2.32.2 security update in charmcraft#1709 was closed without merging due to dependency conflicts; no project changes were applied.
qwen/qwen3.6-35b-a3b β€” β€” Closed without merging due to dependency conflicts. The requests v2.32.2 security update was rejected, and Renovate will skip this version until a compatible release is available.
qwen3.6-35b-a3b-mtp-q6 β€” β€” Updating requests to v2.32.2 to address CVE-2024-35195 was rejected and closed due to dependency conflicts. The update was not merged, and Renovate will ignore this specific version.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/charmcraft#2612 (confidence 95%)

    Merged commit 3a73fbc1 later upgraded Requests from 2.32.5 to 2.33.0, incorporating the security fix.

Related issues

Issue Project State Summary Similarity
#4812 chore(deps): update dependency requests to v2.32.0 [security] - autoclosed snapcraft closed Renovate PR #4812 was autoclosed unmerged after 856 days; the security upgrade was later delivered by #5064 (commit ec4f9b16f), raising requests from 2.31.0 to 2.32.2.
91%
#4856 chore(deps): update dependency requests to v2.32.2 [security] - autoclosed snapcraft closed PR #4856 was autoclosed without merge; the same requests 2.32.2 security update later landed via #5064 (ec4f9b16f).
90%
#61 chore(deps): update dependency requests to v2.32.2 [security] - autoclosed imagecraft closed Renovate's requests 2.32.2 update was autoclosed unmerged; requests was later updated to 2.33.0 by merged PR #308 (commit cbca1c1).
90%
#52 chore(deps): update dependency requests to v2.32.2 [security] - autoclosed imagecraft closed Renovate PR #52 was not merged and was autoclosed; canonical/imagecraft#308 later moved requests to 2.33.0.
86%
#1689 chore(deps): update dependency requests to v2.32.0 [security] - autoclosed charmcraft closed Renovate’s requests 2.32.0 security update was autoclosed unmerged after 864 days, with no reviews, comments, or CI checks.
86%
#574 chore(deps): update dependency requests to <2.33 craft-providers closed Closed unmerged; the requests<2.33 bump became obsolete when PR #663 (commit fe786e8) replaced requests-unixsocket and removed the upper pin.
86%
#1111 chore(deps): update dependency requests to v2.31.0 [security] - abandoned charmcraft closed Renovate's requests 2.28.2 -> 2.31.0 security PR was closed empty (0 files) after autoclosing was skipped due to a modified branch; the identical CVE-2023-32681 upgrade landed via merged Dependabot PR #1110 (10d6d55a).
85%
#386 chore(deps): update dependency types-requests to v2.31.0.10 rockcraft closed Renovate's types-requests 2.31.0.10 update was closed unmerged because it required an incompatible, too-new urllib3; Renovate ignored that version.
79%
#1920 build(deps): update dependency requests to v2.32.2 [security] (main) charmcraft closed Closed unmerged: the requests 2.32.2 security bump was abandoned and that version was ignored by Renovate. A later update, #2612, advanced requests from 2.32.5 to 2.33.0.
78%
#6125 build(deps): update dependency requests to v2.33.0 [security] (main) - autoclosed snapcraft closed Renovate PR #6125 (requests 2.32.5->2.33.0, CVE-2026-25645) was autoclosed as a duplicate; the same bump was merged via Dependabot PR #6127 in commit fce681014.
76%