← Back to issue list

chore(deps): update dependency requests to <2.33

View original Github issue

Metadata

Project
craft-providers
Number
#574
Type
pull request
State
closed
Author
renovate[bot]
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged; the requests<2.33 bump became obsolete when PR #663 (commit fe786e8) replaced requests-unixsocket and removed the upper pin.

Resolution: closed superseded

Reason: Renovate recorded that #574 was closed without merging. The workaround was later made obsolete by merged PR #663 (fe786e8), which replaced requests-unixsocket with requests-unixsocket2 and removed the requests upper bound.

Evaluated by: mr-cal-bot

No scores available.

Issue body

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [requests](https://requests.readthedocs.io) ([source](https://togithub.com/psf/requests), [changelog](https://togithub.com/psf/requests/blob/master/HISTORY.md)) | `<2.32` -> `<2.33` | [![age](https://developer.mend.io/api/mc/badges/age/pypi/requests/2.32.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/requests/2.32.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/requests/2.31.0/2.32.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/requests/2.31.0/2.32.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>psf/requests (requests)</summary> ### [`v2.32.3`](https://togithub.com/psf/requests/blob/HEAD/HISTORY.md#2323-2024-05-29) [Compare Source](https://togithub.com/psf/requests/compare/v2.32.2...v2.32.3) **Bugfixes** - Fixed bug breaking the ability to specify custom SSLContexts in sub-classes of HTTPAdapter. ([#&#8203;6716](https://togithub.com/psf/requests/issues/6716)) - Fixed issue where Requests started failing to run on Python versions compiled without the `ssl` module. ([#&#8203;6724](https://togithub.com/psf/requests/issues/6724)) ### [`v2.32.2`](https://togithub.com/psf/requests/blob/HEAD/HISTORY.md#2322-2024-05-21) [Compare Source](https://togithub.com/psf/requests/compare/v2.32.1...v2.32.2) **Deprecations** - To provide a more stable migration for custom HTTPAdapters impacted by the CVE changes in 2.32.0, we've renamed `_get_connection` to a new public API, `get_connection_with_tls_context`. Existing custom HTTPAdapters will need to migrate their code to use this new API. `get_connection` is considered deprecated in all versions of Requests>=2.32.0. A minimal (2-line) example has been provided in the linked PR to ease migration, but we strongly urge users to evaluate if their custom adapter is subject to the same issue described in CVE-2024-35195. ([#&#8203;6710](https://togithub.com/psf/requests/issues/6710)) ### [`v2.32.1`](https://togithub.com/psf/requests/blob/HEAD/HISTORY.md#2321-2024-05-20) [Compare Source](https://togithub.com/psf/requests/compare/v2.32.0...v2.32.1) **Bugfixes** - Add missing test certs to the sdist distributed on PyPI. ### [`v2.32.0`](https://togithub.com/psf/requests/blob/HEAD/HISTORY.md#2320-2024-05-20) [Compare Source](https://togithub.com/psf/requests/compare/v2.31.0...v2.32.0) **Security** - Fixed an issue where setting `verify=False` on the first request from a Session will cause subsequent requests to the *same origin* to also ignore cert verification, regardless of the value of `verify`. (https://github.com/psf/requests/security/advisories/GHSA-9wx4-h78v-vm56) **Improvements** - `verify=True` now reuses a global SSLContext which should improve request time variance between first and subsequent requests. It should also minimize certificate load time on Windows systems when using a Python version built with OpenSSL 3.x. ([#&#8203;6667](https://togithub.com/psf/requests/issues/6667)) - Requests now supports optional use of character detection (`chardet` or `charset_normalizer`) when repackaged or vendored. This enables `pip` and other projects to minimize their vendoring surface area. The `Response.text()` and `apparent_encoding` APIs will default to `utf-8` if neither library is present. ([#&#8203;6702](https://togithub.com/psf/requests/issues/6702)) **Bugfixes** - Fixed bug in length detection where emoji length was incorrectly calculated in the request content-length. ([#&#8203;6589](https://togithub.com/psf/requests/issues/6589)) - Fixed deserialization bug in JSONDecodeError. ([#&#8203;6629](https://togithub.com/psf/requests/issues/6629)) - Fixed bug where an extra leading `/` (path separator) could lead urllib3 to unnecessarily reparse the request URI. ([#&#8203;6644](https://togithub.com/psf/requests/issues/6644)) **Deprecations** - Requests has officially added support for CPython 3.12 ([#&#8203;6503](https://togithub.com/psf/requests/issues/6503)) - Requests has officially added support for PyPy 3.9 and 3.10 ([#&#8203;6641](https://togithub.com/psf/requests/issues/6641)) - Requests has officially dropped support for CPython 3.7 ([#&#8203;6642](https://togithub.com/psf/requests/issues/6642)) - Requests has officially dropped support for PyPy 3.7 and 3.8 ([#&#8203;6641](https://togithub.com/psf/requests/issues/6641)) **Documentation** - Various typo fixes and doc improvements. **Packaging** - Requests has started adopting some modern packaging practices. The source files for the projects (formerly `requests`) is now located in `src/requests` in the Requests sdist. ([#&#8203;6506](https://togithub.com/psf/requests/issues/6506)) - Starting in Requests 2.33.0, Requests will migrate to a PEP 517 build system using `hatchling`. This should not impact the average user, but extremely old versions of packaging utilities may have issues with the new packaging format. </details> --- ### Configuration 📅 **Schedule**: Branch creation - "every weekend" in timezone Etc/UTC, Automerge - "every weekend" in timezone Etc/UTC. 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/canonical/craft-providers). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNzcuOCIsInVwZGF0ZWRJblZlciI6IjM3LjM3Ny44IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=-->

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed unmerged; the requests<2.33 bump became obsolete when PR #663 (commit fe786e8) replaced requests-unixsocket and removed the upper pin.
qwen/qwen3.6-35b-a3b — closed stale Dependency update PR for `requests` to `<2.33` was closed without merging. Renovate will ignore this update and generate a fresh PR for newer versions.

Update history

Date Change
created

Related work

  • Superseded By: canonical/craft-providers#663 (confidence 98%)

    Merged PR #663 removed the requests cap while replacing requests-unixsocket with requests-unixsocket2.

  • Related To: canonical/craft-providers#572 (confidence 96%)

    Merged PR #572 introduced the requests<2.32 pin that #574 proposed relaxing.

Related issues

Issue Project State Summary Similarity
#1709 chore(deps): update dependency requests to v2.32.2 [security] charmcraft closed Requests 2.32.2 security update #1709 was closed unmerged due to dependency conflicts; its pin change was not applied. A later merged update reached Requests 2.33.0 in #2612 (3a73fbc1).
86%
#61 chore(deps): update dependency requests to v2.32.2 [security] - autoclosed imagecraft closed Renovate's requests 2.32.2 update was autoclosed unmerged; requests was later updated to 2.33.0 by merged PR #308 (commit cbca1c1).
84%
#4812 chore(deps): update dependency requests to v2.32.0 [security] - autoclosed snapcraft closed Renovate PR #4812 was autoclosed unmerged after 856 days; the security upgrade was later delivered by #5064 (commit ec4f9b16f), raising requests from 2.31.0 to 2.32.2.
82%
#52 chore(deps): update dependency requests to v2.32.2 [security] - autoclosed imagecraft closed Renovate PR #52 was not merged and was autoclosed; canonical/imagecraft#308 later moved requests to 2.33.0.
81%
#4856 chore(deps): update dependency requests to v2.32.2 [security] - autoclosed snapcraft closed PR #4856 was autoclosed without merge; the same requests 2.32.2 security update later landed via #5064 (ec4f9b16f).
81%
#649 build(deps): update dependency requests to <2.33 craft-providers closed Closed unmerged because requests 2.32 was incompatible with requests-unixsocket; Renovate ignored the <2.33 update pending a newer release.
80%
#373 chore(deps): update dependency dev/responses to v0.23.2 craft-providers closed Renovate update to responses 0.23.2 was closed unmerged after maintainer mr-cal cited upstream getsentry/responses#657 and requests-unixsocket#69 blockers.
79%
#369 chore(deps): update dependency urllib3 to v2 craft-providers closed Renovate's urllib3 v2 update was closed unmerged because #264 pinned urllib3 to v1 pending msabramo/requests-unixsocket#69.
79%
#1111 chore(deps): update dependency requests to v2.31.0 [security] - abandoned charmcraft closed Renovate's requests 2.28.2 -> 2.31.0 security PR was closed empty (0 files) after autoclosing was skipped due to a modified branch; the identical CVE-2023-32681 upgrade landed via merged Dependabot PR #1110 (10d6d55a).
79%
#512 chore: pin requests version craft-application closed Closed unmerged because the requests<2.32 pin was intentional; follow-up in #511 led to PR #514, which relaxed the constraint and shipped in 4.2.7.
78%