← Back to issue list

fix(charm_builder): de-duplicate installed pkgs

View original Github issue

Metadata

Project
charmcraft
Number
#1750
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged #1750 as 5415dcb7, preventing packages installed from requirements.txt from also being passed to pip, which could break pip.

Resolution: closed resolved

Reason: PR #1750 was approved and merged as commit 5415dcb7. The change de-duplicates charm libraries before invoking pip; related Spread test failures were fixed in #1744 and #1749.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Ensure that charmlibs that are already installed using requirements.txt don't get additionally listed on the command line, as this can break pip. Spread test failures are fixed in #1744 and #1749

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #1750 as 5415dcb7, preventing packages installed from requirements.txt from also being passed to pip, which could break pip.
stealth/space-bunny-alpha — closed resolved Merged in canonical/charmcraft#1750 (commit 5415dcb7), preventing charmlibs installed via requirements.txt from being passed again to pip; related Spread fixes landed in #1744 and #1749.
qwen/qwen3.6-35b-a3b — — Merged. De-duplicates charmlibs already installed via requirements.txt from the command line to prevent pip breakage. Approved by two reviewers, passed CI, and modified two files. Resolves spread test failures addressed in related PRs.
qwen3.6-35b-a3b-mtp-q6 — — Merged fix to prevent duplicate package listings in charm_builder. Charmlibs already installed via requirements.txt are excluded from the command line, resolving pip breakage. Related test failures resolved in #1744 and #1749.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/charmcraft#1744 (confidence 98%)

    PR #1750 identified this merged change as fixing a Spread test failure involving Flask and rustup.

  • Related To: canonical/charmcraft#1749 (confidence 98%)

    PR #1750 identified this merged change as fixing Spread failures caused by the EOL Mantic test base.

Related issues

Issue Project State Summary Similarity
#1891 fix(charm_builder): force-install pip charmcraft merged Merged 2.x hotfix #1891 (df6a92c9) to force-reinstall pip when needed; released in Charmcraft 2.7.3.
71%