fix(charm_builder): force-install pip
Metadata
Current evaluation
Merged hotfix for 2.x forcing pip installation in the charm_builder venv, resolving #1456. Approved by two reviewers, passed CI, and merged successfully.
Suggested action: —
No scores available.
Issue body
The previous version wasn't installing pip if it was already in the venv.
This is the hotfix for 2.x, while https://github.com/canonical/charmcraft/pull/1892 is the hotfix for 3.x
Fixes #1456
CRAFT-2538
Failing spread tests are unrelated and known on the 2.7 branch.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged hotfix for 2.x forcing pip installation in the charm_builder venv, resolving #1456. Approved by two reviewers, passed CI, and merged successfully. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged hotfix for 2.x that forces pip installation in virtual environments. Superseded by PR #1892 for 3.x. Resolves #1456. CI was manually triggered by closing and reopening. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a hotfix for the 2.x branch that forces pip installation in the virtual environment, resolving issue #1456. The author reopened the request to trigger CI before final merge. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1892 fix(charm_builder): force-install pip | charmcraft | merged | Merged hotfix forcing pip installation in the virtual environment when previously skipped. Resolves #1456 for the 3.x branch. Approved by two reviewers and passed CI checks. | |
| #1437 fix(charm_builder): bump minimum pip version to 23 | charmcraft | merged | Merged update bumping the minimum pip version to 23, resolving wheel cache issues with strict dependency flags. Approved by two reviewers, passed CI, and recommended for cherry-picking to the 2.5 branch. | |
| #10 Fix pip installation | charmcraft | merged | Merged a fix for pip installation by using setuptools to include the charmcraft.commands module and correcting the entrypoint to reference the main function. Approved by reviewers and passed CI checks. | |
| #1794 fix(strict-deps): cherry-pick #1784 into 3.1 hotfix branch | charmcraft | merged | Merged cherry-pick of #1784 into the 3.1 hotfix branch. Adds pip check to validate charm virtualenv dependencies, failing the build if requirements are unmet. Resolves #1781. Approved by two reviewers with passing CI checks. | |
| #1784 fix(strict-deps): fail if venv is inconsistent | charmcraft | merged | Merged implementation of pip check to validate charm virtualenv dependencies. The build now fails on inconsistent packages, resolving issue #1781. Approved by two reviewers and passed CI checks. |