← Back to issue list

fix(charm_builder): force-install pip

View original Github issue

Metadata

Project
charmcraft
Number
#1891
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged 2.x hotfix #1891 (df6a92c9) to force-reinstall pip when needed; released in Charmcraft 2.7.3.

Resolution: closed resolved

Reason: Merged as df6a92c9 and shipped in 2.7.3, fixing pip handling in charm_builder virtual environments. The parallel 3.x hotfix was merged in #1892 as 358657b6.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The previous version wasn't installing pip if it was already in the venv. This is the hotfix for 2.x, while https://github.com/canonical/charmcraft/pull/1892 is the hotfix for 3.x Fixes #1456 CRAFT-2538 Failing spread tests are unrelated and known on the 2.7 branch.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged 2.x hotfix #1891 (df6a92c9) to force-reinstall pip when needed; released in Charmcraft 2.7.3.
stealth/space-bunny-alpha — closed resolved Merged 2.x hotfix #1891 (df6a92c9) to force-reinstall pip when needed; released in Charmcraft 2.7.3.
stealth/space-bunny-alpha — closed resolved Merged 2.x hotfix #1891 (df6a92c9) forces pip installation in charm_builder venvs; the parallel 3.x fix merged in #1892 (358657b6).
qwen/qwen3.6-35b-a3b — — Merged hotfix for 2.x forcing pip installation in the charm_builder venv, resolving #1456. Approved by two reviewers, passed CI, and merged successfully.
qwen3.6-35b-a3b-mtp-q6 — — Merged hotfix for 2.x that forces pip installation in virtual environments. Superseded by PR #1892 for 3.x. Resolves #1456. CI was manually triggered by closing and reopening.

Update history

No update history recorded yet.

Related work

Related issues

Issue Project State Summary Similarity
#1892 fix(charm_builder): force-install pip charmcraft merged Merged PR #1892 (358657b6) added a Charmcraft 3.x hotfix to force-upgrade an insufficient pip in existing venvs, fixing #1456.
92%
#1437 fix(charm_builder): bump minimum pip version to 23 charmcraft merged Merged #1437 in commit fe263387, raising charm_builder's minimum pip to 23 so strict dependencies use the prebuilt wheel cache; released in Charmcraft 2.5.4.
77%
#1750 fix(charm_builder): de-duplicate installed pkgs charmcraft merged Merged #1750 as 5415dcb7, preventing packages installed from requirements.txt from also being passed to pip, which could break pip.
71%