← Back to issue list

chore: remove unused package module

View original Github issue

Metadata

Project
charmcraft
Number
#1772
Type
pull request
State
closed
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Removal landed in PR #1776 via commit 027696be; PR #1772 was closed unmerged after 785 days without review or CI.

Resolution: closed superseded

Reason: PR #1776 later removed charmcraft/package.py in commit 027696be, delivering the same cleanup. PR #1772's matching commit 6eb20f38 was not recorded as merged.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The only thing that remained using this module was its set of tests.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Removal landed in PR #1776 via commit 027696be; PR #1772 was closed unmerged after 785 days without review or CI.
stealth/space-bunny-alpha — closed stale The unused package module removal was closed after 785 days without review, CI, comments, or a recorded merge.
qwen/qwen3.6-35b-a3b — — Merged to remove the unused package module, deleting 2,477 lines across two files. The cleanup eliminated test-only dependencies without requiring review.
qwen3.6-35b-a3b-mtp-q6 — — Merged to remove an unused package module, as only its tests remained. The change was integrated without discussion.

Update history

No update history recorded yet.

Related work

  • Superseded By: charmcraft#1776 (confidence 96%)

    Its merged cleanup removed charmcraft/package.py, delivering the deletion proposed by #1772.

Related issues

Issue Project State Summary Similarity
#1773 chore: remove unused providers module charmcraft closed PR #1773 was closed unmerged after 720 days of inactivity; the providers cleanup was later completed by merged PR #1776 at commit 027696be.
82%
#1776 chore: remove unused code charmcraft merged Merged PR #1776 as commit 027696be, deleting 17,571 lines of unused code across 36 files after maintainer review and approval.
81%
#1121 chore: minor cleanup craft-application closed PR #1121 was closed unmerged after 80 days; it received no reviews and the Canonical CLA check failed.
75%
#6079 chore: delete unused file snapcraft merged Merged PR #6079 as commit 75686f3da, deleting a three-line file unused since Snapcraft moved to a pyproject-based setup.
74%
#364 chore(deps): update dependencies rockcraft merged Merged dependency updates in PR #364 via commit 1661d115, changing seven files (+152/-174) after approval by two reviewers.
72%
#734 chore(deps): update documentation dependencies craft-parts closed Renovate PR #734 was closed unmerged after five days of inactivity; its dependency versions appeared in 84e96162 and were later carried forward by 67623b5d.
72%
#1774 chore: remove unused store command implementations charmcraft closed PR #1774 was closed unmerged as stale; store-command cleanup commit 9da46c37 never landed because prerequisite #1773 was also abandoned.
72%
#1830 chore: remove unused file `bases.py` charmcraft merged Merged PR #1830 removed the unused 169-line bases.py module; commit 9a35c1ec records the cleanup.
72%
#191 chore(deps): update development dependencies (non-major) - autoclosed craft-store closed Renovate PR #437 was auto-closed unmerged after 790 days; no resolving commit was provided.
72%
#1357 chore: remove unused docs requirements file craft-parts merged Merged #1357 as commit b472871d, deleting the unused 349-line docs/requirements.txt to stop needless Renovate PR noise; all CI checks passed.
72%