fix(strict-deps): fail if venv is inconsistent
Metadata
Current evaluation
Merged #1784 (fd21df24) made strict-deps builds run pip check and fail on missing venv dependencies, fixing #1781; #1794 backported it to the 3.1 hotfix branch.
Resolution: closed resolved
Reason: PR #1784 was merged as fd21df24 and added virtualenv dependency validation under strict-deps. PR #1794 subsequently merged the fix as 1ac1aa59 on the 3.1 hotfix branch.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This runs `pip check` to ensure that all the packages in the charm virtualenv have all of their required dependencies, failing the build if they do not.
Fixes #1781
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #1784 (fd21df24) made strict-deps builds run pip check and fail on missing venv dependencies, fixing #1781; #1794 backported it to the 3.1 hotfix branch. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1784 as fd21df24, adding pip check to strict-deps builds so inconsistent virtualenvs fail. It fixes #1781 and was backported to 3.1 via #1794. | |
| stealth/space-bunny-alpha | — | closed resolved | PR #1784 (commit fd21df24) merged: strict-deps builds now run `pip check` after populating the charm venv and fail the pack if required dependencies are missing. Fixes #1781; cherry-picked to3.1 hotfix by #1794. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #1784 (fd21df24): strict-deps builds now run pip check and fail when a charm virtualenv has missing dependencies, fixing #1781. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #1784 (fd21df24) to run pip check after strict dependency installation, failing builds when charm venv requirements are missing; fixes #1781 and was backported via #1794. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged implementation of pip check to validate charm virtualenv dependencies. The build now fails on inconsistent packages, resolving issue #1781. Approved by two reviewers and passed CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Adds pip check to validate charm virtualenv dependencies, failing the build on inconsistencies. Resolves #1781. |
Update history
No update history recorded yet.
Related work
-
Related To:
charmcraft#1781
(confidence 100%)
The reported inconsistent-virtualenv packaging bug was fixed by this change.
-
Related To:
charmcraft#1794
(confidence 100%)
Backported #1784 to the 3.1 hotfix branch as commit 1ac1aa59.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1794 fix(strict-deps): cherry-pick #1784 into 3.1 hotfix branch | charmcraft | merged | Merged #1794 as 1ac1aa59, backporting #1784 to the 3.1 hotfix branch so strict-deps builds run pip check and fail on missing virtualenv dependencies. |