← Back to issue list

fix(strict-deps): cherry-pick #1784 into 3.1 hotfix branch

View original Github issue

Metadata

Project
charmcraft
Number
#1794
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged #1794 as 1ac1aa59, backporting #1784 to the 3.1 hotfix branch so strict-deps builds run pip check and fail on missing virtualenv dependencies.

Resolution: closed resolved

Reason: PR #1794 was approved and merged as commit 1ac1aa59. Its cherry-pick of merged PR #1784 added pip check validation for strict-deps builds, resolving #1781.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This runs `pip check` to ensure that all the packages in the charm virtualenv have all of their required dependencies, failing the build if they do not. Fixes #1781

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #1794 as 1ac1aa59, backporting #1784 to the 3.1 hotfix branch so strict-deps builds run pip check and fail on missing virtualenv dependencies.
stealth/space-bunny-alpha — closed resolved Merged #1794 as 1ac1aa59, cherry-picking #1784 into the 3.1 hotfix branch so strict-deps builds run pip check and reject missing venv dependencies, fixing #1781.
stealth/space-bunny-alpha — closed resolved Merged #1794 as 1ac1aa59, cherry-picking #1784 into the 3.1 hotfix branch to run pip check and reject builds with missing charm virtualenv dependencies (#1781).
qwen/qwen3.6-35b-a3b — — Merged cherry-pick of #1784 into the 3.1 hotfix branch. Adds pip check to validate charm virtualenv dependencies, failing the build if requirements are unmet. Resolves #1781. Approved by two reviewers with passing CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged into the 3.1 hotfix branch via cherry-pick of #1784. Adds pip check to validate charm virtualenv dependencies, failing the build if requirements are unmet. Resolves #1781.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/charmcraft#1784 (confidence 100%)

    Merged as fd21df24 and cherry-picked into the 3.1 hotfix branch by #1794.

  • Related To: canonical/charmcraft#1781 (confidence 100%)

    Reported packages missing from the charm virtualenv despite a successful strict-deps pack.

Related issues

Issue Project State Summary Similarity
#1784 fix(strict-deps): fail if venv is inconsistent charmcraft merged Merged #1784 (fd21df24) made strict-deps builds run pip check and fail on missing venv dependencies, fixing #1781; #1794 backported it to the 3.1 hotfix branch.
87%